Skip to content

CPLAT-3974 Remove workaround for DDC bug that is fixed in Dart 2 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lib/src/component_declaration/component_base.dart
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import 'package:meta/meta.dart';
import 'package:over_react/over_react.dart';

import 'package:over_react/src/component_declaration/component_type_checking.dart';
import 'package:over_react/src/util/ddc_emulated_function_name_bug.dart' as ddc_emulated_function_name_bug;
import 'package:over_react/src/util/test_mode.dart';
import 'package:react/react.dart' as react;
import 'package:react/react_client.dart';
Expand Down Expand Up @@ -483,14 +482,6 @@ abstract class UiProps extends MapBase
$CssClassPropsMixin
implements
Map {

UiProps() {
// Work around https://github.com/dart-lang/sdk/issues/27647 for all UiProps instances
if (ddc_emulated_function_name_bug.isBugPresent) {
ddc_emulated_function_name_bug.patchName(this);
}
}

/// Adds an arbitrary [propKey]/[value] pair if [shouldAdd] is `true`.
///
/// Is a noop if [shouldAdd] is `false`.
Expand Down
85 changes: 0 additions & 85 deletions lib/src/util/ddc_emulated_function_name_bug.dart

This file was deleted.

80 changes: 0 additions & 80 deletions test/over_react/util/ddc_emulated_function_name_bug_test.dart

This file was deleted.

2 changes: 0 additions & 2 deletions test/over_react_util_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import 'package:test/test.dart';
import 'over_react/util/class_names_test.dart' as class_names_test;
import 'over_react/util/constants_base_test.dart' as constants_base_test;
import 'over_react/util/css_value_util_test.dart' as css_value_util_test;
import 'over_react/util/ddc_emulated_function_name_bug_test.dart' as ddc_emulated_function_name_bug_test;
import 'over_react/util/dom_util_test.dart' as dom_util_test;
import 'over_react/util/event_helpers_test.dart' as event_helpers_test;
import 'over_react/util/guid_util_test.dart' as guid_util_test;
Expand All @@ -48,7 +47,6 @@ void main() {
class_names_test.main();
constants_base_test.main();
css_value_util_test.main();
ddc_emulated_function_name_bug_test.main();
dom_util_test.main();
event_helpers_test.main();
guid_util_test.main();
Expand Down