Fix stable ci build #327
Merged
Fix stable ci build #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlademann-wf
force-pushed
the
fix-stable-ci-build
branch
from
51a27a9 to
f4a9b58
Compare
Security Insights(3) Vulnerable direct dependencies were detectedansi-regex < 5.0.1 via yarn.lockglob-parent < 5.1.2 via yarn.lockset-value < 4.0.1 via yarn.lockAction Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
force-pushed
the
fix-stable-ci-build
branch
5 times, most recently
from
79191a7 to
62187cd
Compare
+ Widen dep ranges + Add new test tag since the dupe console.log warnings no longer reproduce in dart sdk 2.14.x+
aaronlademann-wf
force-pushed
the
fix-stable-ci-build
branch
from
62187cd to
ca053b6
Compare
greglittlefield-wf
approved these changes
Nov 1, 2021
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get the CI build passing on 2.13.4 and 2.14.x (stable), we need to widen some dependency ranges.
It also appears that dart-lang/sdk#43939 was fixed at some point in the 2.14.x line of release (thus the new tag used to skip those dupe
console.warntests unless we're running the tests in 2.13.x).