Skip to content

Fix stable ci build #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/dart_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ name: Dart CI

on:
push:
branches: [ master ]
branches:
- 'master'
- 'test_consume_*'
pull_request:
branches: [ master ]
branches:
- '*'

jobs:
build:
Expand Down Expand Up @@ -32,18 +35,20 @@ jobs:

- name: Verify formatting
run: dart format --output=none --line-length=120 --set-exit-if-changed .
if: always() && ${{ matrix.sdk }} == 'stable' && steps.install.outcome == 'success'
if: ${{ matrix.sdk == '2.13.4' }}

- name: Analyze project source
run: dart analyze
if: always() && steps.install.outcome == 'success'

- name: Run tests (DDC)
run: dart pub run build_runner test -- --preset dartdevc
run: |
if [ ${{ matrix.sdk }} = '2.13.4' ]; then dart run build_runner test -- --preset dartdevc-legacy; else dart run build_runner test -- --preset dartdevc; fi
if: always() && steps.install.outcome == 'success'
timeout-minutes: 5

- name: Run tests (dart2js)
run: dart pub run build_runner test --release -- --preset dart2js
run: |
if [ ${{ matrix.sdk }} = '2.13.4' ]; then dart run build_runner test -- --preset dart2js-legacy; else dart run build_runner test -- --preset dart2js; fi
if: always() && steps.install.outcome == 'success'
timeout-minutes: 5
10 changes: 8 additions & 2 deletions dart_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@ platforms:
- vm

presets:
dart2js:
dart2js-legacy:
exclude_tags: no-dart2js

dartdevc:
dartdevc-legacy:
exclude_tags: no-dartdevc

dart2js:
exclude_tags: "no-dart2js || no-sdk-2-14-plus"

dartdevc:
exclude_tags: "no-dartdevc || no-sdk-2-14-plus"

tags:
# Variadic children tests of >5 children that fail in Dart 2.7 for an unknown reason, seemingly an SDK bug.
# These tests pass in later Dart SDKs, so we ignore them when running in 2.7.
Expand Down
16 changes: 6 additions & 10 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,13 @@ environment:
sdk: ">=2.11.0 <3.0.0"
dependencies:
js: ^0.6.0
meta: ">=1.1.6 <1.7.0" # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142
meta: ^1.1.6
dev_dependencies:
args: ^1.5.1
build_runner: ^1.6.5
build_test: ^0.10.8
build_web_compilers: ^2.12.0
dependency_validator: ^2.0.0
args: ">=1.5.1 <3.0.0"
build_runner: ">=1.6.5 <3.0.0"
build_test: ">=0.10.8 <3.0.0"
build_web_compilers: ">=2.12.0 <4.0.0"
dependency_validator: ">=2.0.0 <4.0.0"
matcher: ^0.12.5
mockito: ">=4.1.1 <6.0.0"
test: ^1.6.5

dependency_validator:
ignore:
- meta # ignore the pin for now
2 changes: 1 addition & 1 deletion test/js_builds/shared_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ void sharedConsoleWarnTests({@required bool expectDeduplicateSyntheticEventWarni
]);
});
}
}, tags: 'no-dart2js');
}, tags: ['no-dart2js', 'no-sdk-2-14-plus']);

test('logs other duplicate messages properly', () {
consoleWarn('foo');
Expand Down