Added double_tap to express class #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Dec 15, 2017
| if cpx.double_tap: | ||
| print("Double tap!") | ||
| """ | ||
| tapped = self._lis3dh.tapped |
There was a problem hiding this comment.
Want to catch an attribute error here like shake if the lis3dh library is too old? Maybe make the message generic so its exact between the two.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 16, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 2.2 from 2.1.1: > Merge branch 'mrmcwethy-lint' > Add support for I2C/SPI backpack with MCP23008 and 74LS595. New Character_LCD_I2C and Character_LCD_SPI classes. Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 1.0.0 from 0.9.1: > Added double_tap to express class (adafruit/Adafruit_CircuitPython_CircuitPlayground#23) > Added shake_threshold arg and updated docs Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 3.0.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#17 from tannewt/single_double Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#3 from mrmcwethy/lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested, updated docs, verified Sphinx build.