Use setting.toml instead of secrets.py #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kattni These are the changes needed within this library to switch over to settings.toml. It does seem to work as expected with the examples in this repo tested on a PyPortal 8.2.0.
There are examples in other repos, and in various learn guide projects that use secrets.py as well. Many of the learn guides have this page dedicated to internet connection: https://learn.adafruit.com/pyportal-weather-station/internet-connect which also contains code an information related to secrets.py. We'd probably want to have a new revision of that page that is centered around settings.toml instead.