Make buf be the same #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Jan 18, 2020
| @@ -112,9 +112,11 @@ def __init__(self, pin, n, *, bpp=3, brightness=1.0, auto_write=True, pixel_orde | |||
| order[pixel_order] = order_chars[char_no] | |||
| pixel_order = ''.join(order) | |||
|
|
|||
| super().__init__(n, bytearray(self.n * bpp), | |||
| self._buf = bytearray(self.n * bpp) | |||
There was a problem hiding this comment.
ideally we would not allocate two buffers if they are not needed - the original code only alloc'd a new buffer when brightness was < 1
tannewt
reviewed
Jan 21, 2020
| """ | ||
| return self._rawbuf | ||
|
|
||
| @buf.setter |
There was a problem hiding this comment.
Please don't support setting. NeoPixel_SPI and users shouldn't be doing this.
|
As of adafruit/Adafruit_CircuitPython_NeoPixel_SPI#10 NeoPixel SPI uses PixelBuf directly so this is no longer needed. Thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should in theory make .buf behave the same as it did before, by making it the before-adjustment buffer by having NeoPixel hold onto the two buffers and adding a .buf property.
@caternuson HTH