Change base class to pypixelbuf #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tannewt merged 4 commits into adafruit:master from caternuson:pypix

Jan 22, 2020

Collaborator

caternuson commented Jan 22, 2020

As suggested by @tannewt, change base class to Pypixelbuf. This works in a backwards compatible way and also simplifies the code.

Tested with same setup and code as in #9.

caternuson added 2 commits

January 21, 2020 18:08


          change base class to pypixebuf

175796e


          lint

cd04c7a

caternuson requested a review from a team

January 22, 2020 03:53

ladyada approved these changes

View reviewed changes

tannewt requested changes

View reviewed changes

Member

tannewt left a comment

Looks much better overall! Just a couple of things.

neopixel_spi.py Outdated Show resolved Hide resolved

neopixel_spi.py Outdated Show resolved Hide resolved

caternuson added 2 commits

January 22, 2020 11:48


          code review updates


          linterfication

f0982f6

tannewt approved these changes

View reviewed changes

Member

tannewt left a comment

Looks good. Thank you!

tannewt mentioned this pull request

Make buf be the same adafruit/Adafruit_CircuitPython_NeoPixel#68

Closed

tannewt merged commit f6f2c81 into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@42bfc73)

3cdbfb8

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.1.3 from 3.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#18 from markpatterson27/upstream-issue-12

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 4.1.0 from 4.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#30 from sjirwin/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 3.2.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#56 from makermelissa/set_digit_raw
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#55 from makermelissa/set_digit_raw
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#53 from hybotics/port_number_change_from_micropython

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.0.1 from 1.0.0:
  > Update README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel_SPI to 0.3.3 from 0.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel_SPI#10 from caternuson/pypix

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.7 from 3.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#34 from colonwq/add_sdcheck

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 5.0.3 from 5.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#65 from dhalbert/update-dis

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center to 0.8.2 from 0.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center#4 from tannewt/remove_ble_mock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet