Skip to content

Catch Negative Values During Checks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Catch Negative Values During Checks #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dedc3d
fix rate and brightness value checks to catch negative values
sommersoft Jun 14, 2018
a00df83
review fixes; tested both with the full range of values. catches belo…
sommersoft Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adafruit_trellis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def blink_rate(self):

@blink_rate.setter
def blink_rate(self, rate):
if 0 < rate > 3:
if not 0 < rate > 3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the acceptable values? Here, if rate is between 0 and 3, it will fail. So, are the acceptable rates all less than 0 and greater than 3?

Consider trying if not 0 <= rate <= 3:.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptable range is 0 to 3. So yes, this would definitely fail that test. Update coming in a few!

raise ValueError('Blink rate must be an integer in the range: 0-3')
rate = rate & 0x03
self._blink_rate = rate
Expand All @@ -188,7 +188,7 @@ def brightness(self):

@brightness.setter
def brightness(self, brightness):
if 0 < brightness > 15:
if not 0 < brightness > 15:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Is brightness always greater than 15?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range is 0 to 15.

raise ValueError('Brightness must be an integer in the range: 0-15')
brightness = brightness & 0x0F
self._brightness = brightness
Expand Down