Unify iMX RT flash config and add Metro M7 1011 #3522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unifies the flash config to the settings used by the Boot ROM. This makes the config unique per board which allows for changing quad enable and status bit differences per flash device. It also allows for timing differences due to the board layout. This change also tweaks linker layout to leave more ram space for the CircuitPython heap.
arturo182
approved these changes
Oct 8, 2020
|
@jepler Do you have time to review this? |
jepler
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Some items discussed on Discord:
- native ioctl was not actually the problem, but is good to have
- the linker treatment of flexspi_nor_flash_ops.o is no longer required, as individual functions are marked
I didn't spot anything hinky but I was not able to usefully review the flash_config.c file changes. No testing performed.
|
Thanks @jepler! I left fsl as-is because it's directly sourced from the sdk. |
|
@tannewt have you tested this code on any boards? I just tried HEAD of main branch and my Feather RT1011 doesn't boot, it works for the v6 beta 3, bisecting between HEAD and beta 3 led me down to this commit as the breaking one 😅 |
|
Yes. I don't have your boards so I didn't test them. I added you as a reviewer for that reason. I did test on the EVKs (1020 is broken), the new Metro and the Teensys. |
|
Damn 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the flash config to the settings used by the Boot ROM.
This makes the config unique per board which allows for changing
quad enable and status bit differences per flash device. It also
allows for timing differences due to the board layout.
This change also tweaks linker layout to leave more ram space for
the CircuitPython heap.