Fix setup of Espressif PinAlarms#7125
Merged
dhalbert merged 2 commits intoadafruit:mainfrom Oct 26, 2022
Merged
Conversation
Collaborator
dhalbert
commented
Oct 26, 2022
dhalbert
commented
- Fixes PinAlarm not working properly with value=True #6994.
- Code to wait for a pull to happen was wrong -- it only waited in one direction, and it waited essentially forever. Not a good idea anyway, since the pin might be tied firmly to one value or the other. Instead, add a brief delay after setting all pulls.
- Make sure RTC is powered up during sleep.
- Unrelated corrections. to Metro ESP32-S2 debug UART pins.
jepler
approved these changes
Oct 26, 2022
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
no testing performed but the basic change makes sense. waiting forever for a pin to reach a particular status doesn't seem right. 50ms should be generous for almost any RC constant of a pulled I/O pin.
Collaborator
Author
|
I will merge this now in prep for a beta.4 fairly soon. @kattni you can test at your leisure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.