Skip to content

[RAC] SubmenuTrigger throws inside a Section #5858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amitdahan opened this issue Feb 13, 2024 · 1 comment · Fixed by #5863
Closed

[RAC] SubmenuTrigger throws inside a Section #5858

amitdahan opened this issue Feb 13, 2024 · 1 comment · Fixed by #5863

Comments

@amitdahan
Copy link
Contributor

amitdahan commented Feb 13, 2024

Provide a general summary of the issue here

I've been following progress of Submenu support in RAC (#5648) and excited it was very recently merged! 🎉

After trying it, I noticed though it's not yet supported when used together within Sections.

🤔 Expected Behavior?

SubmenuTrigger can be a direct child of Section.

😯 Current Behavior

An error is thrown:

Unsupported element type in Section: submenutrigger

image

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/great-goldstine-rzj4sq

Button on the left opens fine (no Section is used)
Button on the right throws immediately (SubmenuTrigger is nested within a Section)

Version

1.0.2-nightly.4451

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

MacOS 14.3

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@reidbarber
Copy link
Member

Thanks for catching this! Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants