Skip to content

[RAC] Support for submenus within sections #5863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 13, 2024
Merged

[RAC] Support for submenus within sections #5863

merged 6 commits into from
Feb 13, 2024

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Feb 13, 2024 •
edited
Loading

Closes #5858

Adds support for using SubmenuTrigger as a child of Section.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test new story

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 13, 2024

Build successful! 🎉

devongovett
devongovett previously approved these changes Feb 13, 2024
View reviewed changes
@devongovett
Copy link
Member

Tested Safari with VoiceOver.

@rspbot
Copy link

rspbot commented Feb 13, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Feb 13, 2024
@reidbarber reidbarber merged commit 0f6aafc into main Feb 13, 2024
@reidbarber reidbarber deleted the submenu-sections branch February 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@dannify dannify dannify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAC] SubmenuTrigger throws inside a Section
4 participants
@reidbarber @rspbot @devongovett @dannify