Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
fixes hover event handling (events bubble through portals)
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Provisional approval for the code changes, will wait for the new build to test it fully. Will do a full approval after than, pulling it out of the main page example/starter example can be followup
|
Build successful! 🎉 |
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, lets get this in for some final testing
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
approving for testing but let's discuss this one comment
| export const MenuContext = createContext<ContextValue<MenuProps<any>, HTMLDivElement>>(null); | ||
| export const MenuStateContext = createContext<TreeState<unknown> | null>(null); | ||
| export const RootMenuTriggerStateContext = createContext<RootMenuTriggerState | null>(null); | ||
| export const SubmenuContext = createContext<{popoverContainerRef: RefObject<Element>} | null>(null); |
There was a problem hiding this comment.
Do we need to create a separate SubmenuContext for this, or could we have Menu provide PopoverContext with UNSTABLE_portalContainer directly?
There was a problem hiding this comment.
That should work. We'll get a reading refs during render lint warning, but I guess we can ignore.
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } @react-aria/menuAriaSubmenuTriggerProps AriaSubmenuTriggerProps {
+ delay?: number = 200
isDisabled?: boolean
node: RSNode<unknown>
parentMenuRef: RefObject<HTMLElement>
submenuRef: RefObject<HTMLElement>
}
it changed:
|
reidbarber
dismissed
majornista’s stale review
Discussion here: #5648 (comment)
6 participants
Implements submenus in RAC via the SubmenuTrigger component.
✅ Pull Request Checklist:
📝 Test Instructions:
Test new stories and docs.
🧢 Your Project:
RSP