RAC Submenu: remove SubmenuContext and pass portal container via PopoverContext#5803
RAC Submenu: remove SubmenuContext and pass portal container via PopoverContext#5803reidbarber merged 6 commits intomainfrom
Conversation
|
Build successful! 🎉 |
| trigger: 'SubmenuTrigger', | ||
| triggerRef: ref, | ||
| placement: 'end top', | ||
| UNSTABLE_portalContainer: submenuContext.popoverContainerRef.current || undefined, |
There was a problem hiding this comment.
Oh should UNSTABLE_portalContainer really be UNSTABLE_portalContainerRef?
There was a problem hiding this comment.
Then we'd pass the ref itself? instead of taking current out?
There was a problem hiding this comment.
This was released in December, so I think it would be breaking? #5381
There was a problem hiding this comment.
We could add a new UNSTABLE_portalContainerRef prop and try to use that first.
There was a problem hiding this comment.
oh, for some reason I thought we only just added it
There was a problem hiding this comment.
Yeah it was recently added to RSP
There was a problem hiding this comment.
it is technically UNSTABLE, so i don't think changing it would count as a breaking change. however, I still think we should only do it if absolutely necessary
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } |
5 participants
Quick follow-up for #5648 (comment)
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: