Skip to content

[ add ] lemma relating Propositional and Setoid versions of Sublist #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Dec 6, 2024

This implements the lemma requested by @mechvel on zulip

[DELETED]

UPDATED:

  • lemma in Propositional.Properties
  • reduces to a triviality involving Setoid.map
  • Fairbairn threshold?

@jamesmckinna jamesmckinna marked this pull request as draft December 6, 2024 06:24
@jamesmckinna jamesmckinna changed the title [ add ] first attempt at implementing lemma relating Propositional and Setoid versions of Sublist [ add ] lemma relating Propositional and Setoid versions of Sublist Dec 9, 2024
@jamesmckinna jamesmckinna marked this pull request as ready for review December 9, 2024 00:36
@MatthewDaggitt
Copy link
Contributor

I really do feel that this property should live in Propositional.Properties... I've made a PR (#2514) that should make this possible. Let's see if that passes first?

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Dec 9, 2024

I really do feel that this property should live in Propositional.Properties

As with the original Zulip discussion, I'm agnostic about where it best should live, but in fact to my surprise, it was super easy to add the 'right' version (not my original attempt!) of the proof to Setoid, independent of the considerations of #2514 ... but happy to be steered by you downstream... (sic!)

UPDATED: have now added a version of the same lemma to Propositional.Properties for comparison, and it seems, by accident of the parametrisation, that this new version is slightly clunkier. But perhaps it makes for a slightly 'cleaner' dependency graph? (Propositional.Properties depends on Setoid, but not Setoid.Properties depends on Propositional?)

BUT: in any case, I worry a bit about whether the weight outweighs the power of this lemma (in either formulation)?

@MatthewDaggitt
Copy link
Contributor

But perhaps it makes for a slightly 'cleaner' dependency graph? (Propositional.Properties depends on Setoid, but not Setoid.Properties depends on Propositional?)

Yes, I think that this is the key. We should try and have the Propositional files only depend the Setoid files, and not vice-versa.

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Dec 10, 2024

I'll revise in favour of the dependency you favour. DONE.

@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Dec 11, 2024
Merged via the queue into agda:master with commit bacd8a5 Dec 11, 2024
2 checks passed
@jamesmckinna jamesmckinna deleted the mechvel-request branch December 11, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants