Skip to content

Remove implicit parameters from Sublist.Propositional.Properties #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2024
Merged

Remove implicit parameters from Sublist.Propositional.Properties #2514

merged 3 commits into from
Dec 9, 2024

Conversation

MatthewDaggitt
Copy link
Contributor

All the knock on effects seem to be internal to the module only. Cross fingers will pass CI.

@MatthewDaggitt MatthewDaggitt added this to the v2.2 milestone Dec 9, 2024
@MatthewDaggitt MatthewDaggitt mentioned this pull request Dec 9, 2024
Merged
@jamesmckinna
Copy link
Contributor

Thanks @MatthewDaggitt for this.
Given everything you've written so far about parametrisation of Properties modules, this seems to be the 'right' path to take regarding the overall module structure.

jamesmckinna
jamesmckinna approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jamesmckinna jamesmckinna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo passing the tests.
Some suggested tweaks, but they are cosmetic, and could be fixed up once we revisit this issue (module paramterisation vs. variable declarations) more systematically throughout the library.

@jamesmckinna
Copy link
Contributor

Looking good, indeed better!
Happy to merge once tests pass.

@jamesmckinna jamesmckinna added this pull request to the merge queue Dec 9, 2024
Merged via the queue into master with commit 8d5403a Dec 9, 2024
2 checks passed
@jamesmckinna jamesmckinna mentioned this pull request Jan 3, 2025
Open
@MatthewDaggitt MatthewDaggitt deleted the implicit-property-params branch January 3, 2025 09:15
@jamesmckinna jamesmckinna mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmckinna jamesmckinna jamesmckinna approved these changes

Assignees
No one assigned
Labels
breaking refactoring
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewDaggitt @jamesmckinna