Skip to content

fix(recipes): correct model ID to Qwen/Qwen3.8-2.4T-A95B-FP8 - #13265

Merged
chw001 merged 2 commits into
mainfrom
fix/qwen38-model-id-fp8
Aug 14, 2026
Merged

chw001 merged 2 commits into
mainfrom
fix/qwen38-model-id-fp8

Conversation

@chw001

@chw001 chw001 commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Post-merge validation against the actual Hugging Face checkpoint found that the published model ID does not match the tested checkpoint:

  • Published (wrong): Qwen/Qwen3.8-2.4T-A95B
  • Tested checkpoint (correct): Qwen/Qwen3.8-2.4T-A95B-FP8

This PR corrects all 12 files across recipes and docs:

  • 8 deploy.yaml files (--model, --model-path, --served-model-name)
  • model-download.yaml (hf download command)
  • README.md (model references and smoke test commands)
  • Fern catalog hf_id
  • Fern docs page (checkpoint label, prerequisites, smoke test)

Validation

Verified Qwen/Qwen3.8-2.4T-A95B-FP8 exists on Hugging Face and is the checkpoint used during recipe validation on GB200 and GB300.

🤖 Generated with Claude Code


Open in Devin Review

Summary by CodeRabbit

  • Model Updates

    • Updated the Qwen3.8-2.4T-A95B recipe to use the FP8 checkpoint: Qwen/Qwen3.8-2.4T-A95B-FP8.
    • Updated model downloads and serving configurations across SGLang and vLLM deployments to load and serve the FP8 variant.
  • Documentation

    • Updated prerequisites, setup instructions, smoke tests, benchmark commands, links, and configuration examples to reference the FP8 checkpoint consistently.

@chw001
chw001 requested review from a team as code owners August 14, 2026 17:08
@github-actions github-actions Bot added fix documentation Improvements or additions to documentation labels Aug 14, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 833966f1-22d2-450d-be29-14e4a98d1892

📥 Commits

Reviewing files that changed from the base of the PR and between c7aa0bf and 90de83c.

📒 Files selected for processing (12)
  • docs/fern/pages/recipes/_catalog/recipes/qwen-3-8-2-4t-a95b.yaml
  • docs/fern/pages/recipes/model-recipes/qwen-3-8-2-4t-a95b.mdx
  • recipes/qwen3.8-2.4t-a95b/README.md
  • recipes/qwen3.8-2.4t-a95b/model-cache/model-download.yaml
  • recipes/qwen3.8-2.4t-a95b/sglang/agg-gb200-chat/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/sglang/agg-gb300-chat/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/sglang/disagg-gb200-chat/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/sglang/disagg-gb300-chat/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/vllm/agg-gb200-agentic/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/vllm/agg-gb200-chat/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/vllm/agg-gb300-agentic/deploy.yaml
  • recipes/qwen3.8-2.4t-a95b/vllm/agg-gb300-chat/deploy.yaml

Walkthrough

The Qwen3.8-2.4T-A95B recipe now uses the Qwen/Qwen3.8-2.4T-A95B-FP8 checkpoint in its documentation, model download job, SGLang deployments, and vLLM deployments.

Changes

Qwen FP8 checkpoint

Layer / File(s) Summary
Update checkpoint references
docs/fern/pages/recipes/_catalog/recipes/qwen-3-8-2-4t-a95b.yaml, docs/fern/pages/recipes/model-recipes/qwen-3-8-2-4t-a95b.mdx, recipes/qwen3.8-2.4t-a95b/README.md
Documentation, links, prerequisites, smoke tests, benchmarks, and configuration examples now reference the FP8 checkpoint.
Update model download and SGLang loading
recipes/qwen3.8-2.4t-a95b/model-cache/model-download.yaml, recipes/qwen3.8-2.4t-a95b/sglang/*/deploy.yaml
The model cache and SGLang frontend, prefill, and decode workers now load and serve the FP8 checkpoint.
Update vLLM loading and serving
recipes/qwen3.8-2.4t-a95b/vllm/*/deploy.yaml
GB200 and GB300 vLLM workers now load and serve the FP8 checkpoint. The architecture overrides remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 90de8

This PR updates the recipes and documentation to use the validated Hugging Face checkpoint ID; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the correction and validation, but it omits the required template sections, including Related Issues. Add the required Overview, Details, Where should the reviewer start?, and Related Issues sections, with the appropriate issue linkage confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the correction to the Qwen model ID, which is the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Aug 14, 2026
Comment thread docs/fern/index.yml Resolved
…-FP8

Post-merge validation found the checkpoint is Qwen/Qwen3.8-2.4T-A95B-FP8,
not Qwen/Qwen3.8-2.4T-A95B. This commit:

- Updates --model, --model-path, --served-model-name, hf download, and
  hf_id across all 8 deploy.yamls, model-download.yaml, and catalog
- Renames recipes/qwen3.8-2.4t-a95b/ → recipes/qwen3.8-2.4t-a95b-fp8/
  to match the HF model ID (convention: qwen3-235b-a22b-fp8)
- Renames fern catalog yaml, MDX page, id, index entry, and nav slug
  to qwen-3-8-2-4t-a95b-fp8; adds redirect from the old slug
- Adds migration note in README for clusters with cached weights under
  the old repo id
- Updates recipes/README.md display name

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Cheng Wang <chengwa@nvidia.com>
@chw001
chw001 force-pushed the fix/qwen38-model-id-fp8 branch from 85c0206 to a51762f Compare August 14, 2026 17:52
Signed-off-by: chw001 <chengwa@nvidia.com>
@chw001
chw001 merged commit 1d68231 into main Aug 14, 2026
101 of 102 checks passed
@chw001
chw001 deleted the fix/qwen38-model-id-fp8 branch August 14, 2026 21:03
dagil-nvidia added a commit that referenced this pull request Aug 15, 2026
…rence, recipe ID fix

Fix the helm-docs source template's docs link (the generated README was
fixed but generate-helm-docs regenerated the old link, dirtying the
operator check). Adopt main's refreshed vLLM benchmark sampling-flag
reference (#13036 — same shipped flag set, code-verified prose) and the
Qwen3.8 recipe model-ID correction (#13265). Triaged all main docs
commits since the last snapshot point: #13192 and #11723 docs excluded
(features absent from 1.4.0); release-side #13280/#13256 have no docs
impact (AIC-core wheel is a Spica dependency; planner shim wording
verified still correct).

Signed-off-by: Dan Gil <dagil@nvidia.com>
ynpandey-nv pushed a commit that referenced this pull request Aug 21, 2026
Signed-off-by: Cheng Wang <chengwa@nvidia.com>
Signed-off-by: chw001 <chengwa@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
ynpandey-nv pushed a commit that referenced this pull request Aug 25, 2026
Signed-off-by: Cheng Wang <chengwa@nvidia.com>
Signed-off-by: chw001 <chengwa@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fix size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants