Repository navigation
chore(release): backport Qwen3.8-2.4T with vLLM 0.27.1 - #13504
ynpandey-nv merged 11 commits into
Conversation
|
We built this PR's tree locally (CI-shape render + docker build of the vllm-runtime image, amd64) and validated a corrected variant. Summary of what the PR still needs before it can merge. 1. Convert the two file-copy commits into real cherry-picks
We also verified this cannot be repaired incrementally. Picking main's aisimulate fix (#12525) moves the failure to the missing root-workspace crate registration. Syncing the root 2. The chain that worksValidated end to end: with the chain below, the vllm-runtime image builds on the first attempt (~12 min with warm caches), git cherry-pick -m1 c8a33bf20d # 13105 qwen support (currently a file copy)
git cherry-pick -m1 1d68231d95 # 13265 FP8 rename + HF id (already picked)
git cherry-pick -m1 26c02ecdbc # 13232 recipe_specific_images (MISSING from this PR)
git cherry-pick -m1 08f12f739d # 13059 vLLM 0.27.1 (currently a file copy)
git cherry-pick -m1 cfb9622361 # 13324 frontend args fix (already picked)Expected conflicts and the resolutions we used:
3. Add the pieces no pick provides
Happy to share the build logs or the validated branch. |
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com> Signed-off-by: chw001 <52851226+chw001@users.noreply.github.com> Signed-off-by: Shreyas Misra <shreyasm@nvidia.com> Co-authored-by: chw001 <52851226+chw001@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Shreyas Misra <shreyasm@nvidia.com> Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Signed-off-by: Cheng Wang <chengwa@nvidia.com> Signed-off-by: chw001 <chengwa@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Signed-off-by: Dan Gil <dagil@nvidia.com> Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com> Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
…ix parser flag (#13324) Signed-off-by: Cheng Wang <chengwa@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Yogendra Pandey <20666257+ynpandey-nv@users.noreply.github.com> Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
3978519 to
55de8f1
Compare
The isolated pytest-marker-report hook env does not install project deps, so collection fails on tqdm imports from AI Simulate. Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
The composition replay targets main and tag publishes; release backports should not fail on docs-website drift. Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
dagil-nvidia
left a comment
There was a problem hiding this comment.
Review of head 9c40629 against base release/1.4.0-qwen-3.8-2.4t-dev.1: fidelity-clean backport, 1 must-fix, 5 consider. Cherry-pick verification was done by content, never ancestry: 3 of the 5 picks are byte-identical to their main commits, the other 2 are change-line-identical with explainable context drift, and the 90,500-line SBOM swap is exactly main's tool-produced artifact with no additions beyond the version swap. Every release-only commit was individually assessed; all repo gates plus the branch's own generators are green in a head worktree.
Must-fix
docs/fern/pages/recipes/model-recipes/qwen-3-8-2-4t-a95b-fp8.mdx:84,92- broken relative link../kubernetes/quickstart.mdx(resolves to a nonexistent path; every sibling recipe page uses the deeper form). Inherited verbatim from main's copy of the same file, so fix on main first and re-pick, or fix in both - fixing only here gets reverted by the next CP wave.See the [Kubernetes Deployment Guide](../../kubernetes/getting-started/quickstart.mdx).
Consider
.github/workflows/release.yml:183- withBASE_VERSION=1.4.0.dev1, the nightly path would produce1.4.0.dev1.dev<date>(invalid PEP 440) and a 4-part Helm SemVer; latent, since the RC path this branch uses emits valid versions, but strip a trailing.devNbefore appending nightly suffixes.recipes/qwen3.8-2.4t-a95b-fp8/README.md:227plus the 4 SGLang deploy manifests - the README says the branch's pinned stock SGLang base cannot load the checkpoint and v0.5.17-or-patched is required, yet the manifests pin thesglang-runtimetag this branch builds. Confirm that tag is built patched outside this branch's container definition, or the SGLang recipes ship inoperable.- Upstream candidate: this branch removes
--speculative-config mtpfrom three vLLM profiles because stock vLLM 0.27.1 has no MTP mapping for this model, but main still carries the flag in the same three profiles against the same image tag - if the stock-engine claim holds, main's profiles fail at boot. The removal and the two Known-issues bullets belong on main too. container/compliance/base_sboms/manifest.json:166-generated_atis hand-set to main's regeneration timestamp on a hand-edited manifest; a borrowed timestamp on a compliance artifact can mislead an audit. Regenerate or stamp the edit date.- The fla-core and flash-linear-attention MIT license overrides exist nowhere in main's history (they target runtime-image compliance scans); if main's scans hit the same packages, upstream them.
Verified sound
Per-commit fidelity as summarized above, including the manifest split that reassembles main's exact change and the on-branch regeneration of the generated docs (freshness checks green); wheel-vs-crate version split matches the PR description; all changed modules compile and every added import resolves on the branch; catalog validation, CODEOWNERS gates, and the PR's own new artifact test (17/17) pass. Pre-existing on the branch base, not this PR: the catalog README frontmatter warning.
Comment-only review; severity calls stay with the human reviewers.
Signed-off-by: Yogendra Pandey <ypandey@nvidia.com>
472d3cd to
5faa57f
Compare
|
Note on the failing
The must-fix relative link in |
65c4c57
into
release/1.4.0-qwen-3.8-2.4t-dev.1
Summary
Rebuilds the release backport as true delta cherry-picks on the existing
release/1.4.0-qwen-3.8-2.4t-dev.1base (f4625cde5c16c976fc09626b67674bff6a788446). The release branch itself was not rebased or moved.Cherry-picks, in validated order:
c8a33bf20d5478c3fa8fbdb5385d1663af5b496c) — Qwen3.8-2.4T-A95B recipes and docs1d68231d958cfbfae5774454b02fede69f5ffdeb) — FP8 model ID and recipe rename26c02ecdbc86f8d0a9d54e04ba1bb29dfd99357c) — recipe-specific image attribution08f12f739d1f495b394f761f4197d8e852fa6d00) — vLLM 0.27.1cfb9622361e6236d6fbc3b0f094612d4a8a869fc) — SGLang GB200 frontend argumentsAdditional release fixes:
1.4.0.dev1Python and Rust-backed wheelsqwen3_5_moe_textVerification
dynamo.vllm.handlerskeeps the branch-local DP topology helper (no missingdp_topologymodule)vllm_runtime.Dockerfiledoes not install a nonexistentaisimulate*.whl1.4.0.dev1; workspace crates remain1.4.0git diff --checkpasses