Migrate code to use Pydantic V2 #636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
from
eb31438 to
1982137
Compare
Psycojoker
reviewed
Oct 24, 2024
Psycojoker
previously approved these changes
Oct 24, 2024
Contributor
Psycojoker
left a comment
Psycojoker
left a comment
There was a problem hiding this comment.
Apart from some questions, LGTM
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
3 times, most recently
from
b472e50 to
5d068b0
Compare
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
from
5d068b0 to
e4e3d1e
Compare
added 2 commits
October 24, 2024 21:21
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
from
b5e05f1 to
bad782f
Compare
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
from
7cbfce6 to
ac9d738
Compare
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
5 times, most recently
from
bd9a9d6 to
88436b9
Compare
nesitor
force-pushed
the
andres-migrate_pydantic_v2
branch
from
88436b9 to
ee28a85
Compare
1yam
requested changes
Oct 28, 2024
Member
1yam
left a comment
1yam
left a comment
There was a problem hiding this comment.
Except the .model_dump_json() used on aiohttp.Client Response who is not a pydantic model.
Else LGTM
…yg_funct() It used fixture_instance_message.item_content instead of fixture_instance_message_payg.item_content so it raised some errors
…lues - Since it returns string after migrating to Pydantic2, converting the test values into strings
…the best way It raised some errors with mypy. So I checked the documentation to find a better way to serialize the datetime by using the decorator '@field_serializer'
Replacing every deprecated functions by new ones: - @validator → @field_validator - class Config → model_config = ConfigDict() - json_encoders → serialization - orm_mode → from_attributes - utcfromtimestamp() and pytz.utc.localize() → datetime.fromtimestamp(timestamp, tz=timezone.utc) - utcnow() → datetime.now(timezone.utc)
1yam
force-pushed
the
andres-migrate_pydantic_v2
branch
from
a8b272e to
805ef37
Compare
Member
Author
|
Closed in favour of #771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Clickup or Jira tickets : ALEPH-151
Self proofreading checklist
Changes
Used tool
bump-pydanticto migrate Pydantic V1 to Pydantic V2. Also added some manual modifications to fix orphan issues.How to test
Ensure that everything works as usual without issues.