-
Notifications
You must be signed in to change notification settings - Fork 20
Upgrade pydantic v1 to v2 #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
252de0c to
c559b16
Compare
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
c559b16 to
06ae425
Compare
d63b987 to
0051895
Compare
0051895 to
acf0fa4
Compare
…ed with new pydantic v2 annotations.
…eMessageQueryParams
Change from using __annotations__.keys() to model_fields.keys() to properly extract field names from Pydantic v2 models when generating GraphQL queries. This fixes the ValidationError with missing required fields in IndexerEventResponse. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Change from using __annotations__.keys() to model_fields.keys() to properly extract field names from Pydantic v2 models when generating GraphQL queries. This fixes the ValidationError with missing required fields in IndexerEventResponse. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… already implements and validates it.
…an empty instance.
1yam
approved these changes
Apr 9, 2025
Member
1yam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade pydantic v1 to v2
Self proofreading checklist
Changes
How to test
Test it on staging CCN to check if everything is working well, like the whole process and all message types.
Notes
🤖 Generated with Claude Code