Skip to content

Try to fix updating write-only files#122

Merged
alexcrichton merged 1 commit into
mainfrom
try-fix
May 12, 2026
Merged

Try to fix updating write-only files#122
alexcrichton merged 1 commit into
mainfrom
try-fix

Conversation

@alexcrichton

Copy link
Copy Markdown
Owner

No description provided.

@xtqqczze

Copy link
Copy Markdown

It works, but it's a little annoying the standard library requires this workaround.

@alexcrichton

Copy link
Copy Markdown
Owner Author

Once std::fs::set_times is stable I plan on updating to that, and the stabilization may not be far out

@alexcrichton
alexcrichton merged commit 46c34ef into main May 12, 2026
24 checks passed
@alexcrichton
alexcrichton deleted the try-fix branch May 12, 2026 22:37
@xtqqczze

Copy link
Copy Markdown

Thanks, will you yank 0.2.28?

@alexcrichton

Copy link
Copy Markdown
Owner Author

I wasn't planning on it, no, since it's pretty easy to update

@xtqqczze

Copy link
Copy Markdown

I thought best practice was to yank for semver breakage, especially in a patch release?

@xtqqczze

Copy link
Copy Markdown

I guess if you don't want to yank it, we can always work around the issue:

# filetime 0.2.28 is broken, so we need to exclude it from the allowed versions.
filetime = ">=0.2.23, <0.2.28, >=0.2.29"

@alexcrichton

Copy link
Copy Markdown
Owner Author

Can you do filetime = "0.2.29"?

@xtqqczze

Copy link
Copy Markdown

In my view, yanking the release is the most appropriate course of action. However, as the maintainer, the decision on how strictly to adhere to semantic versioning rests with you.

@xtqqczze

Copy link
Copy Markdown
filetime = ">=0.2.23, <0.2.28, >=0.2.29"

Unfortunately cargo doesn't support that syntax: rust-lang/cargo#5286

@alexcrichton Could you help me understand why you can't yank the semver-violating version?

@alexcrichton

Copy link
Copy Markdown
Owner Author

I can, but I won't. It's not something I consider semver-violating, it's just a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants