chore(deps): update rust crate filetime to v0.2.29

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
filetime	workspace.dependencies	patch	0.2.27 → 0.2.29

---

Release Notes

alexcrichton/filetime (filetime)

v0.2.29

Compare Source

v0.2.28

Compare Source

---

Configuration

📅 Schedule: (UTC)

• Branch creation
  • At any time (no schedule defined)
• Automerge
  • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/selinux. tests/misc/selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/touch/empty-file. tests/touch/empty-file is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/touch/fifo. tests/touch/fifo is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/touch/no-rights. tests/touch/no-rights is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

[xtqqczze]

@alexcrichton Breaking change in filetime v0.2.28?

  stderr ───

    thread 'test_touch::test_touch_changes_time_of_file_in_stdout' (70404) panicked at tests/by-util/test_touch.rs:844:10:
    Command was expected to succeed. code: 1
    stdout = 
     stderr = touch: setting times of '/dev/stdout': Permission denied

[alexcrichton]

That looks like it, yeah. Would you be able to reduce this down to a test case?

[xtqqczze]

It seems we do something like this:

coreutils/tests/by-util/test_touch.rs

Lines 831 to 833 in 94b06d9

	fn test_touch_changes_time_of_file_in_stdout() {
	// command like: `touch - 1< ./c`
	// should change the timestamp of c

touch has this highly confusing GNU/coreutils compatibility behavior:

A FILE argument string of - is handled specially and causes touch to change the times of the file associated with standard output.

[alexcrichton]

Would you be able to generate a test that uses the filetime crate? This program:

fn main() {
    let now = std::time::SystemTime::now();
    dbg!(filetime::set_file_times(
        "/dev/stdout",
        now.into(),
        now.into()
    ));
}

passes locally for me for example (no error)

[xtqqczze]

I was able to reproduce the test failure locally on macOS, but I have not been able to identify where the error originates; full backtrace does not help and using a debugger was unfruitful.

[alexcrichton]

Sorry I'm not sure how best to handle this regression otherwise. Locally on macOS the small program I have above passes. Basically without knowing how filetime is being used I'm not sure how to fix a regression.

[xtqqczze]

Some data points for reference:

• The test fails with filetime v0.0.28, including at the original introduction of the test in commit 103dffc.
• The Err is returned here:
  

  coreutils/src/uu/touch/src/touch.rs

  Line 603 in b1c267f

  set_file_times(path, atime, mtime)

[xtqqczze]

@alexcrichton OK I can reproduce, but only when running in the debugger:

fn main() {
    let now = std::time::SystemTime::now().into();
    filetime::set_file_times("/dev/stdout", now, now).unwrap();
}

thread 'main' (1901862) panicked at src/main.rs:3:55:
called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

This fails with filetime v0.0.28, but not v0.0.27

[xtqqczze]

The issue is apparently with the standard library:

fn main() {
    std::fs::File::open("/dev/stdout").unwrap();
}

thread 'main' (1933986) panicked at src/main.rs:2:40:
called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

[xtqqczze]

@alexcrichton The issue is that filetime::set_file_times attempts to open the file for reading, which fails for stdout.

[alexcrichton]

Thanks! Would you be able to test out alexcrichton/filetime#122 and see if it works?

[xtqqczze]

Thanks! Would you be able to test out alexcrichton/filetime#122 and see if it works?

With the following cargo patch, I can confirm all tests pass:

[patch.crates-io]
filetime = { git = 'https://github.com/alexcrichton/filetime.git', branch = 'try-fix' }

[alexcrichton]

Thanks for testing! Published the fix now

[xtqqczze]

We may need to modify Cargo.toml as well unless filetime 0.2.28 is yanked.