Skip to content

community/gitea: upgrade to 1.9.4#10887

Closed
6543 wants to merge 1 commit into
alpinelinux:masterfrom
6543-forks:community_gitea_v1.9.2
Closed

community/gitea: upgrade to 1.9.4#10887
6543 wants to merge 1 commit into
alpinelinux:masterfrom
6543-forks:community_gitea_v1.9.2

Conversation

@6543
Copy link
Copy Markdown
Contributor

@6543 6543 commented Sep 4, 2019 •
edited
Loading

1.8.3 -> 1.9.4

@probot-autolabeler probot-autolabeler Bot added the R-community Community repository label Sep 4, 2019
@6543 6543 changed the title community/gitea: upgrade 1.8.3 -> 1.9.2 [WIP] community/gitea: upgrade 1.8.3 -> 1.9.2 Sep 4, 2019
maxice8
maxice8 reviewed Sep 4, 2019
View reviewed changes
Comment thread community/gitea/APKBUILD Outdated
@maxice8
Copy link
Copy Markdown
Contributor

maxice8 commented Sep 4, 2019

commit title should be

<repo>/<pkg>: upgrade to <pkgver>

@6543 6543 changed the title [WIP] community/gitea: upgrade 1.8.3 -> 1.9.2 [WIP] community/gitea: upgrade to 1.9.2 Sep 4, 2019
This was referenced Sep 4, 2019
Closed
Closed
@6543

This comment has been minimized.

Sign in to view
@6543 6543 changed the title [WIP] community/gitea: upgrade to 1.9.2 community/gitea: upgrade to 1.9.2 Sep 4, 2019
@6543

This comment has been minimized.

Sign in to view
@maxice8 maxice8 added the A-upgrade Upgrades an abuild label Sep 5, 2019
@6543 6543 changed the title community/gitea: upgrade to 1.9.2 community/gitea: upgrade to 1.9.3 Sep 8, 2019
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Sep 8, 2019 •
edited
Loading

@maxice8 while I'm waiting for a upgrade ... a new version arived so I'll update the PR

-> this shuld take a new review
would you do this?

EDIT: test works also on my two test instalation :) and i added spelling correction changes

@6543 6543 mentioned this pull request Sep 8, 2019
Closed
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Sep 24, 2019

@maxice8 is something blocking thebmerge?

I realy like tu use the new version on my instances?

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 2, 2019

hey next version is already coming out how long are you waiting?

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 4, 2019

@andypost you where reacently active at PR can you look at this please
nobodey is reacting (complane issues or aprove&merge it) :(

@andypost
Copy link
Copy Markdown
Contributor

andypost commented Oct 4, 2019

@6543 As I see you did not squashed commits, please use git rebase -i HEAD~12 to squash them into one

@andypost andypost added the S-waiting-maintainer-review Waiting for the package maintainer to review a change label Oct 4, 2019
@andypost andypost requested a review from clandmeter October 4, 2019 11:13
@andypost
Copy link
Copy Markdown
Contributor

andypost commented Oct 4, 2019

@6543 also use git commit --amend to change commit message to community/gitea: upgrade to 1.9.3

@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 4, 2019

@andypost but thanks for your quick and accurate answers!

@6543 6543 mentioned this pull request Oct 4, 2019
Closed
@6543

This comment has been minimized.

Sign in to view
@6543 6543 closed this Oct 5, 2019
@6543 6543 changed the title community/gitea: upgrade to 1.9.3 WIP: community/gitea: upgrade to 1.9.4 Oct 6, 2019
@6543 6543 reopened this Oct 6, 2019
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 6, 2019 •
edited
Loading

need a fix on the gitea site ... so this will upgrade to 1.9.4 instead of ...3

and is WIP for now

@6543 6543 mentioned this pull request Oct 6, 2019
Closed
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 6, 2019

-> go-gitea/gitea#8389

@Cogitri
Copy link
Copy Markdown
Member

Cogitri commented Oct 6, 2019

A bit confused what's the status of this right now. Also, sorry for the wait, Maxice8's notebook broke down.

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 6, 2019 •
edited
Loading

@Cogitri Sory for him ... that's why

  1. This PR worked but after quite some time dependencys had some changes because of the switch from go1.12 to 1.13 - avter it the buld process was brocken for gitea v1.9.x.

  2. Diden't notice the brocken state until at this PR some devs react again (the build failures yesterday)

3. Current state:

Wait for new Release 1.9.4 witch fix gitea build process for v1.9.x

-> go-gitea/gitea#8389

@Cogitri
Copy link
Copy Markdown
Member

Cogitri commented Oct 6, 2019

Alrighty 👍

@andypost andypost mentioned this pull request Oct 8, 2019
Closed
@6543 6543 mentioned this pull request Oct 8, 2019
Closed
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 9, 2019

@andypost gitea v1.9.4 is out :D

@6543 6543 changed the title WIP: community/gitea: upgrade to 1.9.4 community/gitea: upgrade to 1.9.4 Oct 9, 2019
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 9, 2019

@Cogitri

State: ready

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 9, 2019

drone has an selfrelated error
rm: can't remove '/home/buildozer/aports/community/gitea/src/pkg/mod/golang.org/x/crypto@v0.0.0-20190829043050-9756ffdc2472/bn256/bn256_test.go': Permission denied

andypost
andypost previously approved these changes Oct 9, 2019
View reviewed changes
@andypost andypost dismissed their stale review October 9, 2019 15:56

missed broken clean-up task

@andypost
Copy link
Copy Markdown
Contributor

andypost commented Oct 9, 2019

@6543 please use options="chmod-clean"

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 9, 2019

ok

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 9, 2019

@andypost is there a way to tell the CI to build this with go 1.12 not 1.13?

@andypost
Copy link
Copy Markdown
Contributor

andypost commented Oct 9, 2019 •
edited
Loading

@andypost is there a way to tell the CI to build this with go 1.12 not 1.13?

No, current edge version is https://pkgs.alpinelinux.org/packages?name=go&branch=edge

@6543

This comment has been minimized.

Sign in to view
@6543
Update Gitea
efecfcb 
* Update version & sha512
  - 1.8.3 -> 1.9.4
  - Update sha512 of the new source archive
* Delete patch because it was merged with the project
* Add aarch64 again - to test it with CI
  - Delete problem (go-gitea/gitea#5324) from image file
* fix make test
  - Exclude tests
  - make test -> github API has rate restrictions
* fix build cleanup
  - options="chmod-clean"
@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 9, 2019 •
edited
Loading

@andypost @Cogitri @clandmeter @maxice8

pleace review!

@6543
Copy link
Copy Markdown
Contributor Author

6543 commented Oct 12, 2019

do I have to send this to

?

@Cogitri
Copy link
Copy Markdown
Member

Cogitri commented Oct 13, 2019

No, I was just on a trip during weekend, so didn't have time to review it. Sorry for the wait.

@algitbot
Copy link
Copy Markdown

algitbot commented Oct 13, 2019

Merged in 16652f9 by @Cogitri. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Oct 13, 2019
@6543 6543 deleted the community_gitea_v1.9.2 branch October 13, 2019 16:09
@tcely tcely removed the S-waiting-maintainer-review Waiting for the package maintainer to review a change label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxice8 maxice8 maxice8 left review comments

@andypost andypost andypost left review comments

@clandmeter clandmeter Awaiting requested review from clandmeter

Assignees

No one assigned

Labels

A-upgrade Upgrades an abuild R-community Community repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@6543 @maxice8 @andypost @Cogitri @algitbot @tcely