Fix version-validation for GO 1.13 (go-macaron/cors)#8389
Merged
techknowlogick merged 3 commits intoOct 6, 2019
Merged
Conversation
6543
force-pushed
the
fix-go-dependency_macaron-cors
branch
from
7e30999 to
d18ba45
Compare
Member
|
Note for maintainers reviewing: This has been solved for gitea 1.10, however as we changed the upstream dependency we couldn't backport. This will allow 1.9.4 to be built with golang 1.13 |
GiteaBot
added
the
lgtm/need 2
Member
|
@6543 please update vendor/modules.txt as well |
6543
changed the title
Member
|
nvm. I was looking at an old CI build |
6543
changed the title
Member
Author
|
build was succesfull!! |
Member
Author
|
@techknowlogick works 🗡️ |
techknowlogick
approved these changes
Oct 6, 2019
GiteaBot
added
lgtm/need 1
guillep2k
approved these changes
Oct 6, 2019
GiteaBot
added
lgtm/done
Member
Author
|
CI done |
Member
Author
|
now we can build 1.9.x with new fixes ... |
6543
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tip.golang.org/doc/go1.13#version-validation
will solve #8387