This repository was archived by the owner on Oct 2, 2019. It is now read-only.
if (result == value) to "if (angular.equals(result,value)){" #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since there is no sense to init $select.selected and 3 line latter override it with 'ngModel.$viewValue'
since if data=[] is empty when we check for match we got view empty
| @@ -662,7 +662,7 @@ | |||
| for (var p = list.length - 1; p >= 0; p--) { | |||
| locals[$select.parserResult.itemName] = list[p]; | |||
| result = $select.parserResult.modelMapper(scope, locals); | |||
| if (result == value){ | |||
| if (angular.equals(result,value)){ | |||
There was a problem hiding this comment.
Fixes issue observed when comparing against objects from the server.
Closed
|
@perymimon please close this or #405, because they seem to be the same. |
This was referenced Mar 12, 2015
Closed
|
This change will be applied at #748 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without that object from server list not match object on model list