Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix(multiple): formatter binding #748

Merged
merged 1 commit into from
Mar 17, 2015
Merged

fix(multiple): formatter binding #748

merged 1 commit into from
Mar 17, 2015

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Mar 12, 2015

@dimirc
Copy link
Contributor Author

dimirc commented Mar 12, 2015

@renanlecaro commented

I got into some trouble when modifying the model outside of ui-select too
http://plnkr.co/edit/Wboo1fiePaLHKX0eHjxI?p=preview
It looks like it's more of a one way binding than a 2 ways : adding / removing elements with ui-select works well, but the digest cycle of the directive is not always triggered.

Also this PR should solve it now. Updated plunker

@dimirc dimirc changed the title fix(multiple): prevent $select.selected with incorrect values from formatter fix(multiple): formatter binding Mar 12, 2015
@KKrisu
Copy link

KKrisu commented Mar 12, 2015

Looks good for me.
I think you can include unit test I wrote in PR #740 which covers issue #739

@renanlecaro
Copy link

Okay this is weird, It does work on the plunkr but not in my app, and that's because of the angular version. With the latest angular version, the ui-select list updates every two adds

http://plnkr.co/edit/s4M6U89aXYMCDfCUlk0x?p=preview

(i modified the plunks to add unique tags to the list)

@dimirc dimirc force-pushed the fix-multiple-formatter branch from 3041075 to acd1157 Compare March 16, 2015 14:30
@dimirc
Copy link
Contributor Author

dimirc commented Mar 16, 2015

@renanlecaro I did some additional changes. Check updated plunker with angular v1.3.14

dimirc added a commit that referenced this pull request Mar 17, 2015
@dimirc dimirc merged commit 1959ef5 into master Mar 17, 2015
@dimirc dimirc deleted the fix-multiple-formatter branch March 17, 2015 03:41
@KKrisu
Copy link

KKrisu commented Mar 17, 2015

@dimirc I think would be good to add unit test for issue #739, which I wrote in closed PR
https://github.com/angular-ui/ui-select/pull/740/files#diff-26736c4d2d5d1e4c66b6e602618cb367R1694

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null values in ng-model after changing ng-model programmatically on multiselect
3 participants