feat(@schematics/update): add packageGroup version map support #13124
Conversation
|
Hi @hansl! This PR has merge conflicts due to recent upstream merges. |
hansl
force-pushed
the
fix-13015
branch
2 times, most recently
from
32fbbca to
3d011bd
Compare
| } | ||
| } | ||
|
|
||
| if (typeof metadata['packageGroupName'] == 'string') { |
There was a problem hiding this comment.
This conditional set can be removed with the above changes.
|
@clydin PTAL. |
| "ng-update": { | ||
| "packageGroup": { | ||
| "@angular-devkit-tests/update-package-group-1": "^1", | ||
| "@angular-devkit-tests/update-package-group-2": "" |
There was a problem hiding this comment.
Specifying the owning package again in the group and with an empty version specifier is ambiguous. From an npm perspective this would mean install "any version" but the user doesn't want "any version". They want the version of the actual package specified above. They could put the version there as well but then there are two elements that need to be kept in sync within the same file.
There was a problem hiding this comment.
Angular does it and it's kind of suggested (since it's just easier to list all packages in all package.json). It's supported and it's ignored since it's on the command line.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #13015