bugfix(generate): removes bad imports when generating a class #2292
Conversation
|
@deebloo unfortunately the build failed. can you rebase/merge and retest your pull request? |
deebloo
changed the title
| return ng('generate', 'class', 'test-class') | ||
| .then(() => expectFileToExist(classDir)) | ||
| .then(() => expectFileToExist(join(classDir, 'test-class.ts'))) | ||
| .then(() => expectFileToExist(join(classDir, 'test-class.spec.ts'))) |
There was a problem hiding this comment.
This just changed to default to not having a spec in #2475 I believe.
|
Hey, thanks for fixing this! Don't worry too much about keeping the PR updated though, I usually batch-rebase/merge them myself. In your case though, a couple of hours ago a change landed that removed the default specs from classes so it really needs to be rebased. |
|
@filipesilva oh boy does it! |
…te for new apps (angular#2455) Fixes angular#2446
…2379) * Updated ng command options. - "build" now additionally supports --base-hre / -bh, -w - "generate" got cleaned up - "github-pages:deploy" / "gh-pages:deploy" now is supported, too - "init" now knows --routing and --source-dir - "new" also accepts --routing - "serve" dumped --insecure-proxy, --inspr, --output-path, -op, -out and -pxy - "test" now honours --build and --reporters, dumped --config-file, --environment, --filter, --host, --launch, --module, path, --query, reporter, --server, --silent, --test-page and --test-port * Added --aot for "build" and "serve". * Recent the commands "init" and "new" received two more options: "--inline-stile" (alias -is) and "inline-template" (alias -it). Support the, both. * Recently the commands "init" and "new" dropped --blueprint (alias -b).
In addition, reading and using AST on main.ts to figure out the entry module, if not specified.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@filipesilva made a mess. Will open new PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes #2288