-
Notifications
You must be signed in to change notification settings - Fork 12k
bugfix(generate): removes bad imports when generating a class #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
91c8cda
remove unneeded imports
173dffe
add unit tests for generating class
e3aad01
fix var name
9d5566b
Merge branch 'master' into 2288
0a393b3
Merge branch 'master' into 2288
725ba99
Merge branch 'master' into 2288
3324cf7
Merge branch 'master' into 2288
9abe9f9
Merge branch 'master' into 2288
f864ea7
Merge branch 'master' into 2288
584fdc5
Merge branch 'master' of https://github.com/angular/angular-cli into …
775629a
remove unneeded imports
2f10fdf
add unit tests for generating class
7db3bdb
fix var name
a8b3df2
feature(route): allow lazy route reference by relative paths (#2434)
Brocco a499841
bug(route): fix the class names for --routing in ng new (#2435)
Brocco bbea59e
feature(new): allow specification of --inline-style & --inline-templa…
Brocco a3b0fbd
feature(config): config inline template & style in angular-cli.json (…
Brocco 5ed8d38
chore(new): remove blueprint option (#2390)
filipesilva 5ad8754
fix(build): use baseUrl and paths from tsconfig (#2470)
filipesilva 32c5feb
chore(completion): ng completion update for command options (#2379)
catull 360274f
chore(ci): use node 4 instead of 5 (#2469)
filipesilva e1d9930
feat(aot): creating files in a virtual fs. (#2464)
hansl 961c355
feature(blueprints): add spec/no-spec flags to all blueprints (#2382)
Brocco cd7df6c
chore(help): add completion to help (#2483)
filipesilva cd5e0b4
feature(generate): configure spec generation at the project level (#2…
Brocco d11e2cb
chore: simplify inline style & template for mobile apps (#2476)
Brocco dbae273
chore(docs): add typeless package instructions (#2487)
filipesilva c976298
Merge branch '2288' of https://github.com/deebloo/angular-cli into 2288
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 0 additions & 3 deletions
3
packages/angular-cli/blueprints/class/files/__path__/__name__.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import {join} from 'path'; | ||
import {ng} from '../../utils/process'; | ||
import {expectFileToExist} from '../../utils/fs'; | ||
|
||
|
||
export default function() { | ||
// Create the pipe in the same directory. | ||
const classDir = join('src', 'app'); | ||
|
||
return ng('generate', 'class', 'test-class') | ||
.then(() => expectFileToExist(classDir)) | ||
.then(() => expectFileToExist(join(classDir, 'test-class.ts'))) | ||
.then(() => expectFileToExist(join(classDir, 'test-class.spec.ts'))) | ||
|
||
// Try to run the unit tests. | ||
.then(() => ng('test', '--watch=false')); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just changed to default to not having a spec in #2475 I believe.