Skip to content

bugfix(generate): removes bad imports when generating a class #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
91c8cda
remove unneeded imports
Sep 22, 2016
173dffe
add unit tests for generating class
Sep 22, 2016
e3aad01
fix var name
Sep 22, 2016
9d5566b
Merge branch 'master' into 2288
Sep 26, 2016
0a393b3
Merge branch 'master' into 2288
Sep 26, 2016
725ba99
Merge branch 'master' into 2288
Sep 27, 2016
3324cf7
Merge branch 'master' into 2288
Sep 28, 2016
9abe9f9
Merge branch 'master' into 2288
Sep 28, 2016
f864ea7
Merge branch 'master' into 2288
Sep 29, 2016
584fdc5
Merge branch 'master' of https://github.com/angular/angular-cli into …
Oct 3, 2016
775629a
remove unneeded imports
Sep 22, 2016
2f10fdf
add unit tests for generating class
Sep 22, 2016
7db3bdb
fix var name
Sep 22, 2016
a8b3df2
feature(route): allow lazy route reference by relative paths (#2434)
Brocco Sep 30, 2016
a499841
bug(route): fix the class names for --routing in ng new (#2435)
Brocco Sep 30, 2016
bbea59e
feature(new): allow specification of --inline-style & --inline-templa…
Brocco Oct 1, 2016
a3b0fbd
feature(config): config inline template & style in angular-cli.json (…
Brocco Oct 1, 2016
5ed8d38
chore(new): remove blueprint option (#2390)
filipesilva Oct 2, 2016
5ad8754
fix(build): use baseUrl and paths from tsconfig (#2470)
filipesilva Oct 2, 2016
32c5feb
chore(completion): ng completion update for command options (#2379)
catull Oct 2, 2016
360274f
chore(ci): use node 4 instead of 5 (#2469)
filipesilva Oct 2, 2016
e1d9930
feat(aot): creating files in a virtual fs. (#2464)
hansl Oct 2, 2016
961c355
feature(blueprints): add spec/no-spec flags to all blueprints (#2382)
Brocco Oct 3, 2016
cd7df6c
chore(help): add completion to help (#2483)
filipesilva Oct 3, 2016
cd5e0b4
feature(generate): configure spec generation at the project level (#2…
Brocco Oct 3, 2016
d11e2cb
chore: simplify inline style & template for mobile apps (#2476)
Brocco Oct 3, 2016
dbae273
chore(docs): add typeless package instructions (#2487)
filipesilva Oct 3, 2016
c976298
Merge branch '2288' of https://github.com/deebloo/angular-cli into 2288
Oct 3, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/* tslint:disable:no-unused-variable */

import { addProviders, async, inject } from '@angular/core/testing';
import {<%= classifiedModuleName %>} from './<%= fileName %>';

describe('<%= classifiedModuleName %>', () => {
Expand Down
17 changes: 17 additions & 0 deletions tests/e2e/tests/generate/class.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import {join} from 'path';
import {ng} from '../../utils/process';
import {expectFileToExist} from '../../utils/fs';


export default function() {
// Create the pipe in the same directory.
const classDir = join('src', 'app');

return ng('generate', 'class', 'test-class')
.then(() => expectFileToExist(classDir))
.then(() => expectFileToExist(join(classDir, 'test-class.ts')))
.then(() => expectFileToExist(join(classDir, 'test-class.spec.ts')))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just changed to default to not having a spec in #2475 I believe.


// Try to run the unit tests.
.then(() => ng('test', '--watch=false'));
}