Skip to content

fix(@angular/cli): ensure asset output is within the output path #7778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 21, 2017

Build output should be sandboxed within the specified output path. It's currently quite easy to unintentionally (or the remote chance of maliciously) cause an asset or assets to be written to a location on the filesystem outside the project itself.

@clydin clydin force-pushed the restrict-asset-output-path branch from fe7947e to 540cf84 Compare September 21, 2017 23:11
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this is causing silent problems in a bunch of setups.

@filipesilva filipesilva merged commit 206064a into angular:master Sep 25, 2017
@clydin clydin deleted the restrict-asset-output-path branch September 25, 2017 10:47
hansl added a commit to hansl/angular-cli that referenced this pull request Oct 20, 2017
hansl added a commit to hansl/angular-cli that referenced this pull request Oct 22, 2017
hansl added a commit to hansl/angular-cli that referenced this pull request Nov 16, 2017
hansl added a commit that referenced this pull request Nov 20, 2017
hansl added a commit that referenced this pull request Nov 23, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants