-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/cli): add a flag to let assets outside of outDir #8123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of having the flag directly on the asset object definition? #8122 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that ensures this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a security risk. Think reading things from the home directory.
@filipesilva PTAL. |
So the whole project cannot be built outside anymore (using |
@BnSmth, I'm not talking about assets. Instead about entire application. That change in #7778 only checks the asset paths against Simple steps to reproduce:
Do that with both cli versions and you will see in If this was not intentional then I'll create an issue. |
@dzonatan Sorry, my bad. I misunderstood the issue and agree that a fix needs to be put in place. Also, as you said, given this is a breaking change, a note should have been added to the release. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
On top of #7778
Fixes #8122