Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$animate with ngShow is not working properly when used with Angular Material #12519

Closed
ThomasBurleson opened this issue Aug 7, 2015 · 7 comments
Assignees

Comments

@ThomasBurleson
Copy link

The Plunker Demo shows a Form used with ngShow and custom directives/transcludes.

  • If the module ['ngMaterial'] is not included, the Form displays properly
  • If the module ngMaterial is included, the Form is not displayed
  • .ng-hide is never removed
  • If the module ngMaterial is included and a custom ng-show directive is used, the Form is displayed.
  • see script.js for the ngShowDirective override
  • $animate is not used. Instead element.remove() is used.

This issue references angular/material#3941.

Is this a known $animate bug with remove/add class ? Why would $animate work when ngMaterial is NOT a dependency?

@Narretz
Copy link
Contributor

Narretz commented Aug 7, 2015

Hi @ThomasBurleson , thanks for labeling the issue. You should also set the milestone if you know in which timeframe exactly this'll be handled. If it's not clear if this is an angular issue, put it in Purgatory.

@ThomasBurleson
Copy link
Author

@Narretz - While I think this issue hints at a serious subtle bug (either in $animate or Angular Material), I do not want to presume which milestone should be targeted.

@matsko
Copy link
Contributor

matsko commented Aug 7, 2015

There's currently a bug with ngShow in Angular 1.4 that I'm looking into. It's preventing me from releasing 1.4.4. I will reply later today when I have more info on the situation.

@matsko
Copy link
Contributor

matsko commented Aug 7, 2015

The snapshot version of Angular has fixed this: http://plnkr.co/edit/hQ2Q6y5Qi72fePI1VrUl?p=preview

There are still some animation issues with ngShow that I'm fixing, but this issue is good.

@matsko matsko closed this as completed Aug 7, 2015
@ThomasBurleson
Copy link
Author

@matsko - I do not understand your comment.

  • Does the latest code in master already have fixes for this?
  • Do you have a specific commit that fixes this?

BTW, what is a snapshot version ? Is that the most current HEAD build on master ?

@sreeramu
Copy link
Contributor

sreeramu commented Aug 7, 2015

@ThomasBurleson you are correct snapshot version is most current HEAD build on master.

@matsko
Copy link
Contributor

matsko commented Aug 7, 2015

snapshot = latest build on master: https://code.angularjs.org/snapshot/angular.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants