build: run custom tslint rules on new packages #17033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently we didn't run the custom tslint rules for the new packages that have been merged (`youtube-player` and `google-maps`). This is because we have a whitelist of packages we want to run these custom lint rules against. It should be actually the other way around where we only specify the folders we _don't_ want to lint against. That way, new folders are automatically linted and we need to explicitly exclude them if we don't want to run for those.
devversion
added
the
target: minor
googlebot
added
the
cla: yes
josephperrott
approved these changes
Sep 10, 2019
josephperrott
added
pr: lgtm
action: merge
jelbourn
added
target: patch
|
Changed to patch since we released a minor |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
Apparently we didn't run the custom tslint rules for the new packages that have been merged (`youtube-player` and `google-maps`). This is because we have a whitelist of packages we want to run these custom lint rules against. It should be actually the other way around where we only specify the folders we _don't_ want to lint against. That way, new folders are automatically linted and we need to explicitly exclude them if we don't want to run for those. (cherry picked from commit 0d7e038)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we didn't run the custom tslint rules for the new packages
that have been merged (
youtube-playerandgoogle-maps). This isbecause we have a whitelist of packages we want to run these custom
lint rules against.
It should be actually the other way around where we only specify the folders
we don't want to lint against. That way, new folders are automatically linted
and we need to explicitly exclude them if we don't want to run for those.
Note: Marked as target minor because it will not merge safely into the patch branch (as youtube-player is not part of that branch).
I'm not sure if the
module.idis technically needed for those packages (not sure if they are synced into g3), but we should add them for now to satisfy thevalidate-decoratorslint rule. We can remove them as part of the overall cleanup with #13883