build: remove module id references for components in release output

[devversion]

Currently when building the libary with Gulp, we manually inline
resources and remove the moduleId properties. This is actually
why #13883 never came up until Bazel was a thing.

Since we now release with Bazel and rely on the official resource
inlining from @angular/compiler-cli we no longer have control to
omit the moduleId properties. Technically since resources are
inlined, the moduleId is unnecessary and can cause unexpected
behavior. So this could be considered a bug in compiler-cli.

Possible fix: angular/angular#33621.

For now though, since it's unlikely that this is fixed upstream
in RC phase, we manually patch the NGC resource inlining transform
to also remove the moduleId property.

Keeping moduleId can cause errors in the UMD bundles like:

ReferenceError: module is not defined
    at eval (http://localhost:9876/base/node_modules/@angular/material/bundles/material-core.umd.js:1528:35)

[devversion]

angular/angular#33621 should fix the issue upstream in framework. Though this fix is specific to output built with ngc. I wonder how this eventually will look like with ngtsc/Ivy since there doesn't seem to be logic for resource inlining. I guess that's a separate question for the future though.

[jelbourn]

Rather than applying another patch, we could just remove all of the moduleId use and add it back in as part of our sync into Google. That seems like it would be a bit more straightforward to me, since something Google-specific stays in a place that's Google-specific. Thoughts?

[devversion]

If you think that is do-able as part of the sync, then I'd be happy to remove the references to moduleId. That would definitely make things easier on the public side.

[devversion]

Closing in favor of #17626

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}