refactor: remove moduleId from all components#17626
Merged
mmalerba merged 1 commit intoangular:masterfrom Nov 6, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Removes all `moduleId` properties from components. We no longer need them since we inline resources when building the library.
devversion
force-pushed
the
refactor/remove-module-id-properties
branch
from
776c654 to
d9ab448
Compare
devversion
changed the title
devversion
added
target: patch
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn and
mmalerba
as code owners
Member
Author
|
Caretaker: This needs a copybara transform to re-add |
devversion
added
the
blocked
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all
moduleIdproperties from components. We no longerneed them since we inline resources when building the library.
Closes #13883