Skip to content

pathToModuleName wrong on Windows #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evmar opened this issue Feb 22, 2017 · 2 comments
Closed

pathToModuleName wrong on Windows #400

evmar opened this issue Feb 22, 2017 · 2 comments

Comments

@evmar
Copy link
Contributor

evmar commented Feb 22, 2017

On #374:

the root cause is the regex in pathToModuleName function.
"build/testDep.".replace(///g, '.').replace(/^[^a-zA-Z$]/, '').replace(/[^a-zA-Z0-9.$]/g, '_');

We need to handle backslashes in paths on Windows.
@mprobst
Copy link
Contributor

mprobst commented Feb 22, 2017 via email

@b-strauss
Copy link
Contributor

I will take care of this.

@b-strauss b-strauss mentioned this issue Mar 19, 2017
Merged
evmar pushed a commit that referenced this issue Mar 20, 2017
@b-strauss @evmar
Fix line endings mismatch in tests and pathToModuleName on Windows (#438
be433bf 
)

Fixes #436
Fixes #400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evmar @mprobst @b-strauss