This repository was archived by the owner on May 22, 2025. It is now read-only.
Fix line endings mismatch in tests and pathToModuleName on Windows #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmar
reviewed
Mar 19, 2017
test/tsickle_test.ts
Outdated
| } else { | ||
| // Make sure we have proper line endings when testing on Windows. | ||
| if (golden != null) golden = golden.replace(/\r\n/g, '\n'); | ||
| if (output != null) output = output.replace(/\r\n/g, '\n'); |
Contributor
There was a problem hiding this comment.
This seems like the wrong place for this. What about the above check on line 51 for output !== golden? I think this logic should move up to before line 51 perhaps.
Contributor
Author
There was a problem hiding this comment.
Line 54 writes the file on disk. On Windows this would mean \n in written files ... but now that I think about it, output !== golden in line 51 is always false on Windows. I'll change it.
Contributor
Author
|
cc @evmar This can be merged if you approve. Only 3 more tests left that fail on Windows. \o/ |
Contributor
Author
|
@evmar hang on a minute I think I can also fix the remaining tests with the regexp. |
Contributor
Author
|
No, sorry. This can be merged. :) |
evmar
approved these changes
Mar 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
Fixes #400