Skip to content

Optional arguments need to propagate into Closure type #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evmar opened this issue Feb 3, 2016 · 1 comment · Fixed by #54
Closed

Optional arguments need to propagate into Closure type #43

evmar opened this issue Feb 3, 2016 · 1 comment · Fixed by #54

Comments

@evmar
Copy link
Contributor

evmar commented Feb 3, 2016 

function OptionalArgument(x: number, y?: string) {

currently does

function OptionalArgument(/** number */ x, /** string */ y) {

but we need y to be string=.
@evmar evmar mentioned this issue Feb 3, 2016
Merged
@evmar evmar closed this as completed in #44 Feb 3, 2016
@evmar
Copy link
Contributor Author

evmar commented Feb 4, 2016

I got this wrong -- I put an equals sign in but it didn't actually work and the test didn't verify it.

@evmar evmar reopened this Feb 4, 2016
@evmar evmar mentioned this issue Feb 9, 2016
Merged
@evmar evmar closed this as completed in #54 Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

emit full jsdoc for function types
1 participant
@evmar