-
Notifications
You must be signed in to change notification settings - Fork 109
Conversation
@@ -1 +1 @@ | |||
var fn3 = (/** number */ a) => 12; | |||
var fn3 = (a) => 12; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we lost the comment? But it appears in sickle/arrow_fn.ts, so I am very confused.
Should we file a bug at https://github.com/google/closure-compiler/issues for |
|
Note that the weird output with the duplicated comment is due to |
Reassigning to Martin because Rado is out today. |
Travis is failing due to the compile timing out. :~( I guess I gotta refactor things to run the compilations separately. The compile succeeds locally though it takes a while. |
Rather than emitting a type per parameter, emit a jsdoc before the function declaration. This allows us to mark optional arguments properly with the = suffix. Note the changed "optional.ts" test; it now verifies that Closure accepts a missing argument when that argument was missing before. Fixes #43.
With the timeout "fix" in place, this is now ready for review. |
I don't see how you fixed the timeout issue. But LGTM, since it looks fixed. |
I thought |
Rather than emitting a type per parameter, emit a jsdoc
before the function declaration. This allows us to mark optional
arguments properly with the = suffix. Note the changed "optional.ts"
test; it now verifies that Closure accepts a missing argument when
that argument was missing before.
Fixes #43.