Skip to content
This repository was archived by the owner on Sep 16, 2022. It is now read-only.

Refactor Testability #1175

Open
1 of 5 tasks
matanlurey opened this issue Apr 2, 2018 · 1 comment
Open
1 of 5 tasks

Refactor Testability #1175

matanlurey opened this issue Apr 2, 2018 · 1 comment
Labels
area: runtime ♻️ chore
Milestone
R

Comments

@matanlurey
Copy link
Contributor

matanlurey commented Apr 2, 2018 •
edited
Loading

Testability (i.e. the interface for integration testing) is sort of a mess.

We should take the following steps:

  • Write documentation on how it currently works (and what JS interfaces are present)
  • Refactor to use package:js, instead of lots of hand-written JS interop
  • Add some decent functional or integration testing, ourselves
  • Write user-facing documentation on using it
  • Make it optional (i.e. tree-shakable for production applications)
matanlurey added a commit that referenced this issue Apr 4, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
d445fef 
... now with `Testability` working again, and other bug fixes.

Work towards #914.

Closes #1048
Closes #1174.

Filed #1175.
Filed #1179.

PiperOrigin-RevId: 191628083
matanlurey added a commit that referenced this issue Apr 4, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
c455423 
... now with `Testability` working again, and other bug fixes.

Work towards #914.

Closes #1048
Closes #1174.

Filed #1175.
Filed #1179.

PiperOrigin-RevId: 191628083
matanlurey added a commit that referenced this issue Apr 4, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
b157c4a 
... now with `Testability` working again, and other bug fixes.

Work towards #914.

Closes #1048
Closes #1174.

Filed #1175.
Filed #1179.

PiperOrigin-RevId: 191628083
@matanlurey
Copy link
Contributor Author

Docs landed in #1189.

@matanlurey matanlurey self-assigned this Apr 10, 2018
michilu pushed a commit to michilu/scaffold that referenced this issue Apr 13, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
d4c2a08 
... now with `Testability` working again, and other bug fixes.

Work towards angulardart/angular#914.

Closes angulardart/angular#1048
Closes angulardart/angular#1174.

Filed angulardart/angular#1175.
Filed angulardart/angular#1179.

PiperOrigin-RevId: 191628083
leonsenft pushed a commit that referenced this issue Apr 19, 2018
@matanlurey @leonsenft
refactor(Core): Refactor Testability: Use @JS(), remove unused APIs.
288eac3 
Partial work towards #1175.

As far as I can tell, this is a no-op as these features are not used, at all,
and currently we *always* initialize `Testability` for _every_ application. As
we change that, we can re-evaluate how this is setup.

Docs: https://github.com/dart-lang/angular/blob/master/doc/testing/e2e.md
PiperOrigin-RevId: 193262577
leonsenft pushed a commit that referenced this issue Apr 19, 2018
@matanlurey @leonsenft
refactor(Core): Refactor Testability: Use @JS(), remove unused APIs.
b02ec91 
Partial work towards #1175.

As far as I can tell, this is a no-op as these features are not used, at all,
and currently we *always* initialize `Testability` for _every_ application. As
we change that, we can re-evaluate how this is setup.

Docs: https://github.com/dart-lang/angular/blob/master/doc/testing/e2e.md
PiperOrigin-RevId: 193262577
@matanlurey matanlurey removed their assignment Jul 10, 2018
@matanlurey matanlurey added this to the R milestone Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: runtime ♻️ chore
Projects
None yet
Milestone
R
Development

No branches or pull requests
1 participant
@matanlurey