Skip to content
This repository was archived by the owner on Sep 16, 2022. It is now read-only.

Refactor AppplicationRef #914

Closed
matanlurey opened this issue Feb 22, 2018 · 0 comments
Closed

Refactor AppplicationRef #914

matanlurey opened this issue Feb 22, 2018 · 0 comments
Assignees
@matanlurey
Labels
area: runtime ♻️ chore

Comments

@matanlurey
Copy link
Contributor

There are a lot of rarely/unused APIs, few doc comments or good tests, and a lot of unsafe typing going around (I'm running into a bit fixing #913). We should refactor this class into something that looks like decent Dart.
alorenzen pushed a commit that referenced this issue Feb 23, 2018
@matanlurey @alorenzen
fix(*): Various fixes that will become failures in the latest DDC rel…
3c76f19 
…ease(s).

Filed/updated a number of cleanup/refactor bugs while doing this:
* #908
* #916
* #915
* #844
* #914
* dart-lang/sdk#32284

Closes #913.

PiperOrigin-RevId: 186683475
alorenzen pushed a commit that referenced this issue Feb 24, 2018
@matanlurey @alorenzen
fix(*): Various fixes that will become failures in the latest DDC rel…
98ab093 
…ease(s).

Filed/updated a number of cleanup/refactor bugs while doing this:
* #908
* #916
* #915
* #844
* #914
* dart-lang/sdk#32284

Closes #913.

PiperOrigin-RevId: 186683475
alorenzen pushed a commit that referenced this issue Feb 24, 2018
@matanlurey @alorenzen
fix(*): Various fixes that will become failures in the latest DDC rel…
f918b33 
…ease(s).

Filed/updated a number of cleanup/refactor bugs while doing this:
* #908
* #916
* #915
* #844
* #914
* dart-lang/sdk#32284

Closes #913.

PiperOrigin-RevId: 186683475
alorenzen pushed a commit that referenced this issue Feb 24, 2018
@matanlurey @alorenzen
fix(*): Various fixes that will become failures in the latest DDC rel…
b644a41 
…ease(s).

Filed/updated a number of cleanup/refactor bugs while doing this:
* #908
* #916
* #915
* #844
* #914
* dart-lang/sdk#32284

Closes #913.

PiperOrigin-RevId: 186683475
matanlurey added a commit that referenced this issue Feb 25, 2018
@matanlurey
fix(*): Various fixes that will become failures in the latest DDC rel…
f58c508 
…ease(s).

Filed/updated a number of cleanup/refactor bugs while doing this:
* #908
* #916
* #915
* #844
* #914
* dart-lang/sdk#32284

Closes #913.

PiperOrigin-RevId: 186683475
matanlurey added a commit that referenced this issue Apr 4, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
d445fef 
... now with `Testability` working again, and other bug fixes.

Work towards #914.

Closes #1048
Closes #1174.

Filed #1175.
Filed #1179.

PiperOrigin-RevId: 191628083
matanlurey added a commit that referenced this issue Apr 4, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
c455423 
... now with `Testability` working again, and other bug fixes.

Work towards #914.

Closes #1048
Closes #1174.

Filed #1175.
Filed #1179.

PiperOrigin-RevId: 191628083
matanlurey added a commit that referenced this issue Apr 4, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
b157c4a 
... now with `Testability` working again, and other bug fixes.

Work towards #914.

Closes #1048
Closes #1174.

Filed #1175.
Filed #1179.

PiperOrigin-RevId: 191628083
michilu pushed a commit to michilu/scaffold that referenced this issue Apr 13, 2018
@matanlurey
feat(Core): Reland runApp[Legacy][Async].
d4c2a08 
... now with `Testability` working again, and other bug fixes.

Work towards angulardart/angular#914.

Closes angulardart/angular#1048
Closes angulardart/angular#1174.

Filed angulardart/angular#1175.
Filed angulardart/angular#1179.

PiperOrigin-RevId: 191628083
@matanlurey matanlurey self-assigned this Jul 7, 2018
@matanlurey matanlurey mentioned this issue Jul 7, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
area: runtime ♻️ chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matanlurey