Skip to content

Wrong Last orders amount on dashboard #15660 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2018

Conversation

ankurvr
Copy link
Owner

@ankurvr ankurvr commented Jun 2, 2018

Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies magento#15660

Original Pull Request

magento#15536

Fixed Issues (if relevant)

  1. Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies magento/magento2#15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies

Manual testing scenarios

  1. Create 2 Websites with 1 store in each
  2. Set Default website/store base currency as INR (Indian Rupee)
  3. Set another website/store base currency as USD (US Dollar)
  4. Place Order from both websites with with their default currencies.
  5. Now go to Dashboard and set Store View as All Store Views
  6. See Last Orders table and check order's total amounts and all mounts will be in INR (USD orders will be converted to INR with exchange rate
  7. Now change Store View to USD currency website's store which have orders
  8. See Last Orders table and check order's total amounts. You will find those amounts converted to again into INR to USD. But at this point orders are already in USD so no need to convert amounts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

ankurvr and others added 2 commits June 2, 2018 09:59
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies magento#15660
@ankurvr ankurvr merged commit 3b17646 into 2.1-develop Jun 2, 2018
ankurvr pushed a commit that referenced this pull request Jun 12, 2018
 - Merge Pull Request magento#15805 from chirag-wagento/magento2:2.1-develop-PR-port-15790
 - Merged commits:
   1. b01558a
ankurvr pushed a commit that referenced this pull request Jun 12, 2018
Accepted Public Pull Requests:
 - magento#15725: [Backport] Updated font-size variable and standardize #ToDo UI (by @vgelani)
 - magento#15724: [Backport] Moved css from media #TODO (by @vgelani)
 - magento#15736: [Backwardport] Refactor javascript code of  button split widget (by @vijay-wagento)
 - magento#15739: [Backport] fix: support multiple minisearch widget instances (by @vijay-wagento)
 - magento#15719: [Backport 2.1] Fixed return type of wishlist's getImageData in DocBlock (by @rogyar)
 - magento#15716: [BACKPORT 2.1 magento#15695] Fixed a couple of typos (by @dverkade)
 - magento#15803: [Backport] Remove double semicolon from the style sheets. (by @vijay-wagento)
 - magento#15807: [Backport] [Code improvement] (by @hitesh-wagento)
 - magento#15810: [Backport] fix: support multiple minisearch widget instances (by @DanielRuf)
 - magento#15805: [Backport] Make necessary space. #5 (by @chirag-wagento)


Fixed GitHub Issues:
 - magento#15354: Refactor javascript code of button split widget call js component (reported by @amittiwari024) has been fixed in magento#15736 by @vijay-wagento in 2.1-develop branch
   Related commits:
     1. 02453f6
@ankurvr ankurvr deleted the ankurvr-patch-2.1-develop branch September 1, 2018 11:53
ankurvr pushed a commit that referenced this pull request Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants