Skip to content

[Forwardport] Moved css from media #TODO #15536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

[Forwardport] Moved css from media #TODO #15536

merged 1 commit into from
May 30, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented May 26, 2018 •
edited by sidolov
Loading

Original Pull Request

#15416

Description

ToDo UI: move it directly to .page-wrapper (now it doesn't appear in media query cuz of size of css)
Moved CSS from media query as per ToDo UI.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal changed the title Moved css from media #TODO [Forwardport] Moved css from media #TODO May 26, 2018
@RahulKachhadia RahulKachhadia requested a review from zanilee May 26, 2018 13:32
@osrecio osrecio self-assigned this May 28, 2018
@osrecio
Copy link
Member

osrecio commented May 29, 2018

Thanks @vgelani for your contribution, I will process your PR asap.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 29, 2018
@magento-engcom-team magento-engcom-team merged commit 530592b into magento:2.3-develop May 30, 2018
magento-engcom-team pushed a commit that referenced this pull request May 30, 2018
ENGCOM-1702: [Forwardport] Moved css from media #TODO #15536
c54e2dd
magento-engcom-team pushed a commit that referenced this pull request May 30, 2018
ENGCOM-1702: [Forwardport] Moved css from media #TODO #15536
aca9103
@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

This was referenced Jun 1, 2018
Merged
Merged
This was referenced Jun 2, 2018
Closed
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanilee zanilee Awaiting requested review from zanilee

Assignees

@osrecio osrecio

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gelanivishal @osrecio @magento-engcom-team @vkublytskyi @ishakhsuvarov