Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Wrong Last orders amount on dashboard #82

Closed
wants to merge 1 commit into from
Closed

Wrong Last orders amount on dashboard #82

wants to merge 1 commit into from

Conversation

ankurvr
Copy link
Member

@ankurvr ankurvr commented Jun 2, 2018

Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies

Original Pull Request

magento/magento2#15536

Fixed Issues (if relevant)

  1. Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies magento2#15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies

Manual testing scenarios

  1. Create 2 Websites with 1 store in each
  2. Set Default website/store base currency as INR (Indian Rupee)
  3. Set another website/store base currency as USD (US Dollar)
  4. Place Order from both websites with with their default currencies.
  5. Now go to Dashboard and set Store View as All Store Views
  6. See Last Orders table and check order's total amounts and all mounts will be in INR (USD orders will be converted to INR with exchange rate
  7. Now change Store View to USD currency website's store which have orders
  8. See Last Orders table and check order's total amounts. You will find those amounts converted to again into INR to USD. But at this point orders are already in USD so no need to convert amounts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ankurvr
Wrong Last orders amount on dashboard
5a71436 
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ankurvr ankurvr requested a review from sidolov June 2, 2018 10:19
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 11, 2018

Hi @ankurvr , your fix was delivered in the scope of another pull request: magento/magento2#15682 and already present in the code base.
I'm closing this PR as obsolete. Thank you for collaboration!

@sidolov sidolov closed this Jun 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
e99c99e 
…r attribute error message improvements
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
65bce0a 
…r attribute error message improvements - travis ci build code fix
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
7f9f6db 
…r attribute error message improvements - travis ci build code style fix
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
a76e3a3 
…r attribute error message improvements - travis ci build code style fixes
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
3a0599d 
…r attribute error message improvements - code styling fixes
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
6a5b15d 
…r attribute error message improvements - code styling Travis CI build fixes
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
b98f417 
…r attribute error message improvements - code styling Travis CI build fixes
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
import-export-improvements #82 : configurable variations - not a supe…
8db836b 
…r attribute error message improvements - code styling Travis CI build fixes
magento-engcom-team added a commit that referenced this pull request Jul 21, 2018
@magento-engcom-team
ENGCOM-2174: import-export-improvements #82 : super attribute error m…
6223196 
…essage improvements #115

 - Merge Pull Request magento-engcom/import-export-improvements#115 from tadhgbowe/import-export-improvements:import-export-issue-82-error-messaging
 - Merged commits:
   1. e99c99e
   2. 65bce0a
   3. 7f9f6db
   4. a76e3a3
   5. 3a0599d
   6. 6a5b15d
   7. b98f417
   8. 8db836b
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
ENGCOM-2174: import-export-improvements #82 : super attribute error m…
1aefab8 
…essage improvements #115
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
f01227c 
Accepted Public Pull Requests:
 - magento/magento2#16961: [Forwardport] Improve "Invalid country code" error message on tax import (by @ihor-sviziev)
 - magento/magento2#16962: [Forwardport] Add Confirm Modal Width (by @ihor-sviziev)
 - magento/magento2#16769: [Forwardport] Added 'title' attribute to 'img' tag in knockout template files. (by @sanganinamrata)
 - magento/magento2#16947: [Forwardport] Fix newsletter subscription behaviour for registered customer.  (by @eduard13)
 - magento/magento2#16876: FIXED: FTP user and password strings urldecoded (by @javierperezm)
 - magento/magento2#16875: Remove unused comments from _initDiscount() function (by @mageprince)
 - magento/magento2#16888: Code improvement (by @mage2pratik)
 - magento/magento2#16892: [Forwardport] Fix for #12081: missing translations in the js-translations.json (by @mage2pratik)
 - magento-engcom/import-export-improvements#115: import-export-improvements #82 : super attribute error message improvements (by @tadhgbowe)


Fixed GitHub Issues:
 - magento/magento2#12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. (reported by @jhruehl) has been fixed in magento/magento2#16892 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 18d11f5
magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2018
@nikshostko
Merge pull request #82 from magento-epam/2.3-develop
5e87343 
Merge 2.3-develop to EPAM-PR-4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sidolov sidolov Awaiting requested review from sidolov

Assignees
No one assigned
Labels
2.3-develop Component: Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankurvr @magento-cicd2 @sidolov @magento-engcom-team