Restore NO_FLOOD to OVS ports after reconnecting the OVS bridge#4654
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4654 +/- ##
==========================================
- Coverage 69.86% 69.57% -0.30%
==========================================
Files 403 402 -1
Lines 59778 58421 -1357
==========================================
- Hits 41765 40644 -1121
+ Misses 15189 14975 -214
+ Partials 2824 2802 -22
*This pull request uses carry forward flags. Click here to find out more.
|
xliuxu
force-pushed
the
fix_no_flood_bridge_reconnect
branch
from
d35922c to
23f835a
Compare
Contributor
Author
|
/test-all |
xliuxu
force-pushed
the
fix_no_flood_bridge_reconnect
branch
from
23f835a to
383a006
Compare
hongliangl
reviewed
Feb 23, 2023
Comment on lines
+394
to
+391
| } else { | ||
| klog.InfoS("Set port no-flood success", "PortName", port.Name) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } else { | |
| klog.InfoS("Set port no-flood success", "PortName", port.Name) | |
| } | |
| } | |
| klog.InfoS("Set port no-flood successfully", "PortName", port.Name) | |
Comment on lines
+598
to
+599
| klog.Info("Restoring OF port configs to OVS bridge") | ||
| err := i.restorePortConfigs() | ||
| if err != nil { | ||
| klog.ErrorS(err, "Failed to restore OF port configs") | ||
| } else { | ||
| klog.Info("Restore OF port configs completed") | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| klog.Info("Restoring OF port configs to OVS bridge") | |
| err := i.restorePortConfigs() | |
| if err != nil { | |
| klog.ErrorS(err, "Failed to restore OF port configs") | |
| } else { | |
| klog.Info("Restore OF port configs completed") | |
| } | |
| klog.InfoS("Restoring OF port configs to OVS bridge") | |
| if err := i.restorePortConfigs(); err != nil { | |
| klog.ErrorS(err, "Failed to restore OF port configs") | |
| } else { | |
| klog.InfoS("Port configs restoration completed") | |
| } |
| func (c *Controller) createIPSecTunnelPort(nodeName string, nodeIP net.IP) (int32, error) { | ||
| portName := util.GenerateNodeTunnelInterfaceName(nodeName) | ||
| interfaceConfig, exists := c.interfaceStore.GetNodeTunnelInterface(nodeName) | ||
|
|
xliuxu
force-pushed
the
fix_no_flood_bridge_reconnect
branch
2 times, most recently
from
6a528dc to
8f29ecb
Compare
tnqn
reviewed
Feb 27, 2023
Comment on lines
+378
to
+383
| ovsCtlClient := ovsctl.NewClient(i.ovsBridge) | ||
| ovsPorts, err := i.ovsBridgeClient.GetPortList() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to list OVS ports: %w", err) | ||
| } | ||
| for _, port := range ovsPorts { |
Member
There was a problem hiding this comment.
don't we already cache all TrafficControl and IPSec interfaces? I think they can be fetched via GetInterfacesByType more efficiently?
Contributor
Author
There was a problem hiding this comment.
Done. Thanks for the suggestion!
| return 0, fmt.Errorf("failed to get of_port of IPsec tunnel port for Node %s", nodeName) | ||
| } | ||
| // Set external_ids to the port for upgrade case. | ||
| if err := c.ovsBridgeClient.SetPortExternalIDs(portName, ovsExternalIDs); err != nil { |
Member
There was a problem hiding this comment.
initInterfaceStore has a logic to fill missed AntreaInterfaceTypeKey, I think this could be moved there to unify the logic.
tnqn
reviewed
Feb 27, 2023
| AntreaUplink = "uplink" | ||
| AntreaHost = "host" | ||
| AntreaTrafficControl = "traffic-control" | ||
| AntreaIPsec = "ipsec" |
Member
There was a problem hiding this comment.
perhaps ipsec-tunnel to be more specific.
xliuxu
force-pushed
the
fix_no_flood_bridge_reconnect
branch
2 times, most recently
from
d2472a2 to
35afabf
Compare
Contributor
Author
|
/test-all |
xliuxu
force-pushed
the
fix_no_flood_bridge_reconnect
branch
from
35afabf to
161f575
Compare
The NO_FLOOD configuration is lost when the OVS daemon is restarted. Currently, the only way to recover this configuration is by restarting the agent. This pull request adds logic to recover the configuration when receiving OVS reconnection events. Signed-off-by: Xu Liu <xliu2@vmware.com>
xliuxu
force-pushed
the
fix_no_flood_bridge_reconnect
branch
from
161f575 to
fe02848
Compare
Contributor
Author
|
/test-e2e |
tnqn
added
the
action/release-note
Member
|
/skip-e2e |
Member
|
/skip-conformance its failure is because the tested svc IP which was supposed to be unreachable happened to be a real server IP. |
This was referenced Mar 2, 2023
This was referenced Mar 24, 2023
This was referenced Mar 27, 2023
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
…ea-io#4654) The NO_FLOOD configuration is lost when the OVS daemon is restarted. Currently, the only way to recover this configuration is by restarting the agent. This pull request adds logic to recover the configuration when receiving OVS reconnection events. Signed-off-by: Xu Liu <xliu2@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NO_FLOOD configuration is lost when the OVS daemon is restarted. Currently, the only way to recover this configuration is by restarting the agent. This pull request adds logic to recover the configuration when receiving OVS reconnection events.