Skip to content

Automated cherry pick of #4419: Set NO_FLOOD to IPsec tunnel ports #4470: Fix that Service routes may get lost when starting on Windows #4654: Restore NO_FLOOD to OVS ports after reconnecting the OVS #4711: Fix route deletion for Service ClusterIP and LoadBalancerIP#4764

Closed
luolanzone wants to merge 4 commits into
antrea-io:release-1.8from
luolanzone:automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.8

Conversation

@luolanzone

Copy link
Copy Markdown
Contributor

Cherry pick of #4419 #4470 #4654 #4711 on release-1.8.

#4419: Set NO_FLOOD to IPsec tunnel ports
#4470: Fix that Service routes may get lost when starting on Windows
#4654: Restore NO_FLOOD to OVS ports after reconnecting the OVS
#4711: Fix route deletion for Service ClusterIP and LoadBalancerIP

For details on the cherry pick process, see the cherry pick requests page.

xliuxu and others added 3 commits March 27, 2023 10:48
Set NO_FLOOD to IPsec tunnel ports to avoid ARP flooding.

Signed-off-by: Xu Liu <xliu2@vmware.com>
Fix antrea-io#4467

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
The NO_FLOOD configuration is lost when the OVS daemon is restarted.
Currently, the only way to recover this configuration is by restarting
the agent. This pull request adds logic to recover the configuration
when receiving OVS reconnection events.

Signed-off-by: Xu Liu <xliu2@vmware.com>
@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Mar 27, 2023
@codecov

codecov Bot commented Mar 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4764 (b5e0bd0) into release-1.8 (a9dfcf4) will decrease coverage by 2.64%.
The diff coverage is 26.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.8    #4764      +/-   ##
===============================================
- Coverage        65.91%   63.28%   -2.64%     
===============================================
  Files              304      304              
  Lines            46648    46692      +44     
===============================================
- Hits             30750    29549    -1201     
- Misses           13494    14790    +1296     
+ Partials          2404     2353      -51     
Flag Coverage Δ *Carryforward flag
integration-tests 35.09% <2.53%> (-0.02%) ⬇️
kind-e2e-tests 42.80% <26.05%> (-6.05%) ⬇️
unit-tests 45.20% <ø> (+0.02%) ⬆️ Carriedforward from a9dfcf4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/interfacestore/types.go 61.11% <0.00%> (-8.34%) ⬇️
pkg/agent/proxy/proxier.go 53.11% <13.63%> (-13.36%) ⬇️
...gent/controller/noderoute/node_route_controller.go 57.06% <20.00%> (-0.67%) ⬇️
pkg/agent/route/route_linux.go 35.91% <33.33%> (-17.45%) ⬇️
pkg/agent/agent.go 49.78% <40.00%> (-0.79%) ⬇️
pkg/agent/interfacestore/interface_cache.go 75.94% <75.00%> (-4.98%) ⬇️
pkg/agent/util/net.go 27.23% <100.00%> (-20.15%) ⬇️

... and 48 files with indirect coverage changes

@luolanzone luolanzone force-pushed the automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.8 branch from f479f24 to 7b220f8 Compare March 27, 2023 08:08
When proxyAll is enabled, AntreaProxy needs to install routes in the
host network namespace to redirect traffic to OVS for load balancing.
For a Service with multiple ports, multiple ServicePorts are generated
and processed. The previous code installed the route for a ClusterIP or
a LoadBalancerIP multiple times when such a Service was created, and
uninstalled the route multiple times when it was deleted, leading to a
few problems.

This patch adds a serviceIPRouteReferences which tracks the references
of Service IPs' routes. The key is the Service IP and the value is the
the set of ServiceInfo strings. With the references, we install a route
exactly once as long as it's used by any ServicePorts and uninstall it
exactly once when it's no longer used by any ServicePorts.

This patch also fixes an issue that the route for ClusterIP was not
removed on Windows Nodes after the Service was removed.

Fixes antrea-io#4361

Signed-off-by: Quan Tian <qtian@vmware.com>
@luolanzone luolanzone force-pushed the automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.8 branch from 7b220f8 to b5e0bd0 Compare March 27, 2023 08:24
@luolanzone luolanzone closed this Mar 28, 2023
@luolanzone luolanzone deleted the automated-cherry-pick-of-#4419-#4470-#4654-#4711-upstream-release-1.8 branch March 28, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants