cleanup: remove deprecated allowances from Clock & Rent sysvars#355
Open
anand9125 wants to merge 2 commits intoanza-xyz:mainfrom
Open
cleanup: remove deprecated allowances from Clock & Rent sysvars#355anand9125 wants to merge 2 commits intoanza-xyz:mainfrom
anand9125 wants to merge 2 commits intoanza-xyz:mainfrom
Conversation
febo
reviewed
Feb 24, 2026
Collaborator
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Almost there, just one comment.
.gitignore
Outdated
| @@ -1,2 +1,5 @@ | |||
| /node_modules | |||
| /target | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Let's revert this change please.
Author
There was a problem hiding this comment.
Reverted the .gitignore change. Please take another look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes legacy
#![allow(deprecated)]attributes and outdated comments from Clock and Rent sysvar implementations.Changes
sdk/src/sysvars/clock.rs
#![allow(deprecated)]sol_get_clock_sysvarsdk/src/sysvars/rent.rs
#![allow(deprecated)]Both sysvars already use the generic sysvar fetch via:
impl_sysvar_get!(CLOCK_ID, 0)
impl_sysvar_get!(RENT_ID, 0)
Impact
No behavioral change. This is strictly a cleanup to remove obsolete allowances and comments.
Testing