Skip to content

cleanup: remove deprecated allowances from Clock & Rent sysvars #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anand9125 wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −8
Open

cleanup: remove deprecated allowances from Clock & Rent sysvars #355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a856f
cleanup: remove deprecated allowances from Clock & Rent sysvars
anand9125 Feb 23, 2026
45b65be
Revert .gitignore change per review
anand9125 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
/node_modules
/target

Copy link
Collaborator

@febo febo Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change please.

Copy link
Author

@anand9125 anand9125 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the .gitignore change. Please take another look.

Copy link
Author

@anand9125 anand9125 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@febo

# Personal notes (do not commit)
PINOCCHIO_NOTES.md
4 changes: 0 additions & 4 deletions sdk/src/sysvars/clock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
//! Information about the network's clock, ticks, slots, etc.

// This is necessary since `sol_get_clock_sysvar` is deprecated but still used here.
// It can be removed once the implementation uses `get_sysvar` instead.
#![allow(deprecated)]

use crate::{
account::{AccountView, Ref},
error::ProgramError,
Expand Down
4 changes: 0 additions & 4 deletions sdk/src/sysvars/rent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
//!
//! This is required for the rent sysvar implementation.

// This is necessary since `sol_get_rent_sysvar` is deprecated but still used here.
// It can be removed once the implementation uses `get_sysvar` instead.
#![allow(deprecated)]

use {
crate::{
account::{AccountView, Ref},
Expand Down