(iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber.#825
Merged
dpogue merged 1 commit intoapache:masterfrom Apr 18, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 13 13
Lines 1849 1849
=======================================
Hits 1372 1372
Misses 477 477 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
I hate disregarded warnings at compile time.
Description
Existing code was converting to NSNumber with wrong init method for the type.
Rather than change the method called I switched to auto boxing the values which automatically does the right thing in less code.
Testing
Ran npm test
Checklist
(platform)if this change only applies to one platform (e.g.(android))