Skip to content

(iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber. #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpogue merged 1 commit into from
Apr 18, 2020
+2 −2
Merged

(iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber. #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CordovaLib/Classes/Public/CDVPluginResult.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ - (CDVPluginResult*)initWithStatus:(CDVCommandStatus)statusOrdinal message:(id)t
{
self = [super init];
if (self) {
status = [NSNumber numberWithInt:statusOrdinal];
status = @(statusOrdinal);
message = theMessage;
keepCallback = [NSNumber numberWithBool:NO];
}
Expand Down
2 changes: 1 addition & 1 deletion CordovaLib/Classes/Public/CDVViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ - (UIInterfaceOrientationMask)supportedInterfaceOrientations

- (BOOL)supportsOrientation:(UIInterfaceOrientation)orientation
{
return [self.supportedOrientations containsObject:[NSNumber numberWithInt:orientation]];
return [self.supportedOrientations containsObject:@(orientation)];
}

- (UIView*)newCordovaViewWithFrame:(CGRect)bounds
Expand Down